[feat] add timeout and ability to cat debug logs #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryang20718
force-pushed
the
user/ryang/timeout_and_logging
branch
2 times, most recently
from
c567f02
to
226e456
Compare
Ryang20718
force-pushed
the
user/ryang/timeout_and_logging
branch
from
226e456
to
321704b
Compare
Ryang20718
commented
May 31, 2024
| @@ -419,6 +419,49 @@ jobs: | |||
| npm install | |||
| ./action_tests/assert.js all-hold-the-line-no-upload-id | |||
|
|
|||
| pull_request_expect_trunk_check_timeout: | |||
There was a problem hiding this comment.
This is not tested (since I can't run CI). Let me know if I should add a test elsewhere!
det
reviewed
Jun 7, 2024
github-merge-queue bot
pushed a commit
to chezmoi-sh/atlas
that referenced
this pull request
Jun 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [trunk-io/trunk-action](https://github.com/trunk-io/trunk-action) | action | patch | `v1.1.15` -> `v1.1.16` | [](https://securityscorecards.dev/viewer/?uri=github.com/trunk-io/trunk-action) | --- ### Release Notes <details> <summary>trunk-io/trunk-action (trunk-io/trunk-action)</summary> ### [`v1.1.16`](https://github.com/trunk-io/trunk-action/releases/tag/v1.1.16) [Compare Source](https://github.com/trunk-io/trunk-action/compare/v1.1.15...v1.1.16) ##### What's Changed - \[feat] add timeout and ability to cat debug logs by [@​Ryang20718](https://github.com/Ryang20718) in [trunk-io/trunk-action#245 ##### New Contributors - [@​Ryang20718](https://github.com/Ryang20718) made their first contribution in [trunk-io/trunk-action#245 **Full Changelog**: trunk-io/trunk-action@v1...v1.1.16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chezmoi-sh/atlas). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to DelineaXPM/github-workflows
that referenced
this pull request
Jul 18, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Type | Update | |---|---|---|---| | [actions/checkout](https://github.com/actions/checkout) | [`b4ffde6` -> `692973e`](https://github.com/actions/checkout/compare/b4ffde6...692973e) | action | digest | | [akhilmhdh/contributors-readme-action](https://github.com/akhilmhdh/contributors-readme-action) | [`v2.3.6` -> `v2.3.10`](https://github.com/akhilmhdh/contributors-readme-action/compare/v2.3.6...v2.3.10) | action | patch | | [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request) | [`e9fabac` -> `0723387`](https://github.com/amannn/action-semantic-pull-request/compare/e9fabac...0723387) | action | digest | | [elgohr/go-vulncheck-action](https://github.com/elgohr/go-vulncheck-action) | [`7221c71` -> `e73217f`](https://github.com/elgohr/go-vulncheck-action/compare/7221c71...e73217f) | action | digest | | [github/codeql-action](https://github.com/github/codeql-action) | [`c2dc671` -> `e113c55`](https://github.com/github/codeql-action/compare/c2dc671...e113c55) | action | digest | | [trunk-io/trunk-action](https://github.com/trunk-io/trunk-action) | [`v1.1.11` -> `v1.1.16`](https://github.com/trunk-io/trunk-action/compare/v1.1.11...v1.1.16) | action | patch | | [trunk-io/trunk-action](https://github.com/trunk-io/trunk-action) | [`6522858` -> `86b68ff`](https://github.com/trunk-io/trunk-action/compare/6522858...86b68ff) | action | digest | --- ### Release Notes <details> <summary>akhilmhdh/contributors-readme-action (akhilmhdh/contributors-readme-action)</summary> ### [`v2.3.10`](https://github.com/akhilmhdh/contributors-readme-action/releases/tag/v2.3.10): Contributors-Readme-Action v2.3.10 [Compare Source](https://github.com/akhilmhdh/contributors-readme-action/compare/v2.3.9...v2.3.10) 1. Fixed missing `tbody` [#​68](https://github.com/akhilmhdh/contributors-readme-action/issues/68) 2. Updated readme with the new github action permission in yaml [#​63](https://github.com/akhilmhdh/contributors-readme-action/issues/63) ### [`v2.3.9`](https://github.com/akhilmhdh/contributors-readme-action/releases/tag/v2.3.9): Contributors-Readme-Action v2.3.9 [Compare Source](https://github.com/akhilmhdh/contributors-readme-action/compare/v2.3.8...v2.3.9) #### What's Changed - Update README.md by [@​KPCOFGS](https://github.com/KPCOFGS) in [akhilmhdh/contributors-readme-action#76 - Fix null name, no capitalize & introduce eslint fix command by [@​melroy89](https://github.com/melroy89) in [akhilmhdh/contributors-readme-action#77 #### New Contributors - [@​KPCOFGS](https://github.com/KPCOFGS) made their first contribution in [akhilmhdh/contributors-readme-action#76 - [@​melroy89](https://github.com/melroy89) made their first contribution in [akhilmhdh/contributors-readme-action#77 ### [`v2.3.8`](https://github.com/akhilmhdh/contributors-readme-action/releases/tag/v2.3.8): Contributors-Readme-Action v2.3.8 [Compare Source](https://github.com/akhilmhdh/contributors-readme-action/compare/v2.3.7...v2.3.8) Removed check for push to enable manual run ### [`v2.3.7`](https://github.com/akhilmhdh/contributors-readme-action/releases/tag/v2.3.7): Contributors-Readme-Action v2.3.7 [Compare Source](https://github.com/akhilmhdh/contributors-readme-action/compare/v2.3.6...v2.3.7) #### What's Changed - Update node12 -> node18 by [@​jessebot](https://github.com/jessebot) in [akhilmhdh/contributors-readme-action#59 - Bump json5 from 2.2.0 to 2.2.3 by [@​dependabot](https://github.com/dependabot) in [akhilmhdh/contributors-readme-action#61 - Bump minimatch from 3.0.4 to 3.1.2 by [@​dependabot](https://github.com/dependabot) in [akhilmhdh/contributors-readme-action#56 - Bump [@​actions/core](https://github.com/actions/core) from 1.6.0 to 1.9.1 by [@​dependabot](https://github.com/dependabot) in [akhilmhdh/contributors-readme-action#54 - refactor: update set-output deprecated command by [@​dtcMLOps](https://github.com/dtcMLOps) in [akhilmhdh/contributors-readme-action#74 #### New Contributors - [@​jessebot](https://github.com/jessebot) made their first contribution in [akhilmhdh/contributors-readme-action#59 - [@​dtcMLOps](https://github.com/dtcMLOps) made their first contribution in [akhilmhdh/contributors-readme-action#74 </details> <details> <summary>trunk-io/trunk-action (trunk-io/trunk-action)</summary> ### [`v1.1.16`](https://github.com/trunk-io/trunk-action/releases/tag/v1.1.16) [Compare Source](https://github.com/trunk-io/trunk-action/compare/v1.1.15...v1.1.16) ##### What's Changed - \[feat] add timeout and ability to cat debug logs by [@​Ryang20718](https://github.com/Ryang20718) in [trunk-io/trunk-action#245 ##### New Contributors - [@​Ryang20718](https://github.com/Ryang20718) made their first contribution in [trunk-io/trunk-action#245 **Full Changelog**: trunk-io/trunk-action@v1...v1.1.16 ### [`v1.1.15`](https://github.com/trunk-io/trunk-action/releases/tag/v1.1.15) [Compare Source](https://github.com/trunk-io/trunk-action/compare/v1.1.14...v1.1.15) ##### What's Changed - Adds inputs/outputs to the upgrade action ([#​241](https://github.com/trunk-io/trunk-action/issues/241)) - Attempts to install the correct pnpm version in setup-ci action([#​243](https://github.com/trunk-io/trunk-action/issues/243)) **Full Changelog**: trunk-io/trunk-action@v1.1.14...v1.1.15 ### [`v1.1.14`](https://github.com/trunk-io/trunk-action/releases/tag/v1.1.14) [Compare Source](https://github.com/trunk-io/trunk-action/compare/v1.1.13...v1.1.14) ##### What's Changed - Adds a `signoff` option to add a Signed-Off-By line to the commits created by the upgrade action ([#​238](https://github.com/trunk-io/trunk-action/issues/238)) **Full Changelog**: trunk-io/trunk-action@v1.1.13...v1.1.14 ### [`v1.1.13`](https://github.com/trunk-io/trunk-action/releases/tag/v1.1.13) [Compare Source](https://github.com/trunk-io/trunk-action/compare/v1.1.12...v1.1.13) ##### What's Changed - Continues on failure to install node packages, if user doesn't have a trunk.yaml ([#​236](https://github.com/trunk-io/trunk-action/issues/236)) **Full Changelog**: trunk-io/trunk-action@v1.1.12...v1.1.13 ### [`v1.1.12`](https://github.com/trunk-io/trunk-action/releases/tag/v1.1.12) [Compare Source](https://github.com/trunk-io/trunk-action/compare/v1.1.11...v1.1.12) ##### What's Changed - Adds an action to install trunk: `trunk-io/trunk-action/install@v1` ([#​234](https://github.com/trunk-io/trunk-action/issues/234)) **Full Changelog**: trunk-io/trunk-action@v1.1.11...v1.1.12 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/DelineaXPM/github-workflows). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be times where the trunk action is unresponsive and is hung in CI.
To understand whether this is a linter or trunk cli issue, we'll need logs to confirm.
This PR adds the following optional inputs
timeout-secondsandcat-trunk-debug-logswhich will wrap the trunk check action with the unix
timeoutcommand should the user supply an argument fortimeout-secondsShould the user specify
cat-trunk-debug-logs: true, the trunk action will also cat out cli & daemon logs from.trunk/logs/Unfortunately,
timeout-minutesdoesn't work incomposite-actionssee actions/runner#1979and https://github.com/orgs/community/discussions/50481
Test Plan:
End to End test to ensure timeout + logs work
End to End test to ensure timeout works