Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer commit log processing #845

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Buffer commit log processing #845

merged 1 commit into from
Oct 12, 2022

Conversation

mcastorina
Copy link
Collaborator

@mcastorina mcastorina commented Oct 12, 2022

Some very large commits take a lot of time to process, which we can make progress on while we are scanning the contents of other commits.

Tested with duckduckgo/tracker-radar:

  • Without buffered channel: 200 minutes
  • With buffered channel: 110 minutes
  • Speedup: 1.8x

Note: git log for the repo took around ~60 minutes which is the theoretical fastest we could scan the repo (via that dependency).

Some very large commits take a lot of time to process, which we can make
progress on while we are scanning the contents of other commits.
@mcastorina mcastorina requested a review from a team as a code owner October 12, 2022 11:14
Copy link
Collaborator

@trufflesteeeve trufflesteeeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool find! LGTM!

@mcastorina mcastorina merged commit 4aab7b7 into main Oct 12, 2022
@mcastorina mcastorina deleted the buffered-commits branch October 12, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants