Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[THOG-746] - Add decoder type to results. #835

Merged
merged 1 commit into from
Oct 6, 2022
Merged

[THOG-746] - Add decoder type to results. #835

merged 1 commit into from
Oct 6, 2022

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Oct 5, 2022 •
edited
Loading

-Include the decoder type in the secret results.
Screen Shot 2022-10-05 at 4 35 20 PM

@ahrav ahrav requested a review from a team as a code owner October 5, 2022 23:38
dustin-decker
dustin-decker approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@dustin-decker dustin-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! We'll also want to include the archive handler even though it's not a decoder package

@ahrav
Copy link
Collaborator Author

ahrav commented Oct 6, 2022

Great! We'll also want to include the archive handler even though it's not a decoder package

Ahh good point.

@ahrav
Copy link
Collaborator Author

ahrav commented Oct 6, 2022

As a note, we will add archive decoding info on the file level. So I will leave it out of this PR.

@ahrav ahrav merged commit 1280028 into main Oct 6, 2022
@ahrav ahrav deleted the THOG-746-recoder-decoder-with-secret-results branch October 6, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustin-decker dustin-decker dustin-decker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @dustin-decker