Move head and base normalization to source #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill-rich
force-pushed
the
move_head_base_normalize
branch
from
d2309c8
to
1921fda
Compare
mcastorina
approved these changes
Sep 23, 2022
| @@ -453,6 +458,55 @@ func (s *Git) ScanRepo(ctx context.Context, repo *git.Repository, repoPath strin | |||
| return nil | |||
| } | |||
|
|
|||
| func normalizeConfig(scanOptions *ScanOptions, repo *git.Repository) (err error) { | |||
There was a problem hiding this comment.
Suggestion (optional): We may be able to minimize our if statements by starting the function with something like:
if scanOptions.BaseHash == "" || scanOptions.HeadHash == "" {
// Nothing to do.
return nil
}
// ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a bad head or base being used in git source.