[Thog-371] Utilize config struct for engine scans #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ahrav
commented
Aug 9, 2022
•
ahrav
commented
- Define a config struct within sources that encompasses all the configurations used for all the engine scanning integrations.
- Construct each config within main for each source using functional args.
- Pass the config as the second argument to each of the engine scan methods.
- Update all the tests.
mcastorina
reviewed
Aug 9, 2022
mcastorina
approved these changes
Aug 10, 2022
| if err != nil { | ||
| return errors.WrapPrefix(err, "unable to resolve head ref", 0) | ||
| } else { | ||
| headRef = head.String() | ||
| headCommit, _ = repo.CommitObject(plumbing.NewHash(baseRef)) | ||
| c.HeadRef = head.String() |
There was a problem hiding this comment.
Comment: Since c is a pointer, this line will actually change the value for the caller, which may be unexpected or not desired. Not a huge concern because I don't think we use the config again after running the scan, but I thought I'd at least mention it.
There was a problem hiding this comment.
yea i did realize that, but figured that it was okay since as you mentioned we only use the cfg in the switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.