Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SlackTokens option for slack credentials #647

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

trufflesteeeve
Copy link
Collaborator

Is there a way to do this without the tokens name, and instead having just bot_token and app_token be the credential? I don't think so but I am less familiar with protobufs.

@dustin-decker
Copy link
Contributor

It's needed to ensure that we can differentiate on credential types.
It is possible to include it as top level fields, but then you lose out on having different credential types and need to have application logic sift through sparse fields (ie. token is blank but app_token and bot_token are not, and the reverse. also the invalid combinations).

@trufflesteeeve trufflesteeeve merged commit 20051e7 into main Jul 18, 2022
@trufflesteeeve trufflesteeeve deleted the add-new-slack-credential branch July 18, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants