Only include one result per AWS Key ID, preferably verified #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ignore unverified results that match hashes, because they are probably just hashes.
trufflesteeeve
requested review from
bill-rich,
mcastorina,
dustin-decker and
ahrav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ignore unverified results that match hashes, because they are
probably just hashes.
I'm currently working on tests for this, but wanted to get the logic out early to make sure we're comfortable with these changes. They will essentially increase the number of unverified results we return, while also helping us ignore the fact that any kind of hash technically matches the shape of an AWS secret, with an incredibly tiny probability of actually being one. But we'll still attempt to verify any hashes, so in case they are live, we'll still include them.