Cleanup individual repositories after scanning #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufflesteeeve
requested review from
bill-rich,
mcastorina,
dustin-decker and
ahrav
dustin-decker
approved these changes
Jun 8, 2022
|
We should probably preserve the current behavior. That can still be done with these anonymous functions. |
trufflesteeeve
force-pushed
the
cleanup-repo-after-scan
branch
from
13b0e58
to
bcb77ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deferred os.RemoveAlls mean that anytime there's a scan of a lot of repositories, they won't be deleted from disk until the entire scan is done. This fixes that.
But it also changes some behavior - currently if there's an error getting or scanning a repo, the scan ends. Should we keep that? I can easily change this to do so. Or should it log the issue and continue scanning, as I've currently implemented it? (Though for directories, the current behavior remains in place)