[THOG-270] Fix scanning crash for git source without TLS. #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/sources/git/git_test.go
Outdated
| }{ | ||
| { | ||
| uri: "https://github.com/dustin-decker/secretsandstuff.git", | ||
| path: "/var/folders/1m/m4kl5q2102bfr4k4566nmf800000gn/T/trufflehog2276311773", |
There was a problem hiding this comment.
See the comments in the other MR, we shouldn't expect a particular path here because it's OS dependent.
There was a problem hiding this comment.
worth noting this can probably made a bit better with some more thought, but this should also work for the time being as the concept is tested I think well enough.
dustin-decker
approved these changes
May 2, 2022
|
Merge conflict now |
ahrav
force-pushed
the
THOG-270-fix-scanning-crash-git-source-no-tls
branch
from
af7bbf5
to
c0317e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix crash when trying to scan a git source without TLS/SSL.
Why?
Should be able to scan a source without TLS/SSL.
How?
Update the switch case statement to include
httpas a case in addition tohttpsTesting?
Updated the unit tests to cover the new scenario.
Screenshots (optional)
n/a
Anything Else?