Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore safedir when scanning git repo #438

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Ignore safedir when scanning git repo #438

merged 1 commit into from
Apr 21, 2022

Conversation

bill-rich
Copy link
Collaborator

Fixes issue where safedir prevents running git log against a mounted docker directory where directory ownership doesn't match. The issue was preventing the trufflehog action from working properly.

@bill-rich bill-rich requested a review from a team April 21, 2022 05:37
ahrav
ahrav approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@ahrav ahrav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: Might be worth adding a test for ScanCommits in the near future, especially since it's exported. Although given the dependency on glgo might be a little bit of work. Nonetheless could be beneficial maybe?

@bill-rich bill-rich merged commit d4c3391 into main Apr 21, 2022
@bill-rich bill-rich deleted the disable_safedir_for_scanning branch April 21, 2022 17:02
bill-rich added a commit that referenced this pull request May 2, 2022
@bill-rich
Ignore safedir when scanning git repo (#438)
0efc44f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustin-decker dustin-decker dustin-decker approved these changes

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bill-rich @dustin-decker @ahrav