updating jiratoken and jiratokenV2 to use tri-state verification #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x1
commented
Sep 1, 2023
| } else { | ||
| s1.VerificationError = err |
There was a problem hiding this comment.
this would have always been nil
rosecodym
approved these changes
Sep 5, 2023
can you elaborate on what you mean? i haven't done any testing beyond running the tests locally, and the tests cover all of potential failure cases i believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Description:
updating jiratoken and jiratokenV2 to use tri-state verification
updating/fixing tests�
also updating
tokentosecreton the tests which is the standard across our tests so far as i've seenChecklist:
make test-community)?make lintthis requires golangci-lint)?