Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

needed perms for running workflows against forks #1348

Merged
merged 2 commits into from
May 19, 2023
Merged

needed perms for running workflows against forks #1348

merged 2 commits into from
May 19, 2023

Conversation

codevbus
Copy link
Contributor

No description provided.

@codevbus codevbus requested a review from a team as a code owner May 18, 2023 22:11
ahrav
ahrav approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!!

@codevbus
Copy link
Contributor Author

Is this test expected to fail? - https://github.com/trufflesecurity/trufflehog/actions/runs/5025916930/jobs/9013512614?pr=1348

@mcastorina
Copy link
Collaborator

Is this test expected to fail? - https://github.com/trufflesecurity/trufflehog/actions/runs/5025916930/jobs/9013512614?pr=1348

No, it looks like it's failing from a 500 error. I'll try rerunning it.

@codevbus codevbus merged commit 1d9d6b6 into main May 19, 2023
@codevbus codevbus deleted the add-read-perms-for-gha branch May 19, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codevbus @mcastorina @ahrav