-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RawV2 Results to the JSON Output #1273
Add RawV2 Results to the JSON Output #1273
Conversation
@dustin-decker done, I saw the other PR and was waiting for your input, I removed my changes so the GCP detector shouldn't be affected by this PR now. Let me know if there's anything else, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @yilmi!
Thanks @dustin-decker, I don't want to push it but do you think you folks could release this change along with the rest of @ahrav work on the utf-8 and base64 decoders? We have our scheduled scan running on Friday evenings, I'd like to consume the latest changes to get all the nice changes from v3.32.0 and this. If not that's ok, I can also wait ;-) |
just tagged v3.32.1 |
@ahrav did work on adding a RawV2 field in the Result struct to permit the collection of multipart secrets. This work was completed in #710 last year.
While the current implementation collects RawV2 for a lot of detector types, this value is never passed to the JSON Result output.
This PR changes this behavior: