Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use md5 hash for checking if key exists #1257

Merged
merged 1 commit into from
May 15, 2023
Merged

use md5 hash for checking if key exists #1257

merged 1 commit into from
May 15, 2023

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Apr 14, 2023

No description provided.

@ahrav ahrav requested a review from a team as a code owner April 14, 2023 14:13
rosecodym
rosecodym reviewed Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the test suite doesn't cover this? It seems like an obvious candidate.

@ahrav ahrav merged commit 6db770f into main May 15, 2023
@ahrav ahrav deleted the use-md5-hash-for-check branch May 15, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosecodym rosecodym rosecodym left review comments

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrav @mcastorina @rosecodym