Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] - add support for json service account and service account file #1185

Merged
merged 1 commit into from
Mar 16, 2023
Merged

[chore] - add support for json service account and service account file #1185

merged 1 commit into from
Mar 16, 2023

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Mar 16, 2023

  • enterprise requires json service account whereas oss will only use a file

@ahrav ahrav marked this pull request as ready for review March 16, 2023 19:58
@ahrav ahrav requested review from a team as code owners March 16, 2023 19:58
@ahrav ahrav merged commit 6193509 into main Mar 16, 2023
@ahrav ahrav deleted the chore-add-service-account-file-gcs branch March 16, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @mcastorina