-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #1167 by adding support for the AWS_SESSION_TOKEN #1170
Resolve #1167 by adding support for the AWS_SESSION_TOKEN #1170
Conversation
7c8db1e
to
e16447a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
@iamjpotts can you sign the CLA please? We won't be able to accept the contribution until you do. |
@dustin-decker thanks for your interest in my contribution. The CLA is in review and I should have feedback in 1-2 weeks on it. |
I'm trying to figure out the mechanics/process for a corporate entity to sign the CLA. For individuals, it's obvious - click the grey/yellow button above and follow thru with the electronic acceptance. What's the mechanics/process for a corporate entity? |
@iamjpotts it should be the same process, that CLA covers individuals on behalf of a company too. See point 4)
|
Thanks for the response. By |
…KEN environment variable and adding a --session-token cli arg
81a1cad
to
2efeaed
Compare
That's correct @iamjpotts, as long as you have received permission to make contributions on behalf of your employer and they have waived their rights to your contributions, the standard CLA signed by your GitHub user covers it. This is the relevant attestation from point 4:
|
I have received written permission to make this contribution on behalf of my employer, |
This is a fix for #1167.
Edited to add:
This change is submitted on behalf of my employer,
El Toro.com, LLC
and I have internal written approval to do so.