Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #1167 by adding support for the AWS_SESSION_TOKEN #1170

Merged

Conversation

iamjpotts
Copy link
Contributor

@iamjpotts iamjpotts commented Mar 10, 2023

This is a fix for #1167.

Edited to add:

This change is submitted on behalf of my employer, El Toro.com, LLC and I have internal written approval to do so.

@iamjpotts iamjpotts requested review from a team as code owners March 10, 2023 22:40
@CLAassistant
Copy link

CLAassistant commented Mar 10, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@dustin-decker dustin-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@dustin-decker
Copy link
Contributor

@iamjpotts can you sign the CLA please? We won't be able to accept the contribution until you do.

@iamjpotts
Copy link
Contributor Author

@dustin-decker thanks for your interest in my contribution.

The CLA is in review and I should have feedback in 1-2 weeks on it.

@iamjpotts
Copy link
Contributor Author

@dustin-decker

I'm trying to figure out the mechanics/process for a corporate entity to sign the CLA. For individuals, it's obvious - click the grey/yellow button above and follow thru with the electronic acceptance.

What's the mechanics/process for a corporate entity?

@dustin-decker
Copy link
Contributor

@iamjpotts it should be the same process, that CLA covers individuals on behalf of a company too. See point 4)

You represent that you are legally entitled to grant the above license. If your employer(s) has rights to intellectual property that you create that includes your Contributions, you represent that you have received permission to make Contributions on behalf of that employer, that your employer has waived such rights for your Contributions to the Company, or that your employer has executed a separate Corporate CLA with the Company.

@iamjpotts
Copy link
Contributor Author

@dustin-decker

Thanks for the response.

By same process - do you mean that only my account iamjpotts needs to sign the CLA in the scenario where the PR has IP from my employer (which is the case with this PR)? No other signatures required, such as by an executive officer of the company?

iamjpotts and others added 2 commits April 3, 2023 14:19
…KEN environment variable and adding a --session-token cli arg
@dustin-decker
Copy link
Contributor

That's correct @iamjpotts, as long as you have received permission to make contributions on behalf of your employer and they have waived their rights to your contributions, the standard CLA signed by your GitHub user covers it. This is the relevant attestation from point 4:

you represent that you have received permission to make Contributions on behalf of that employer, that your employer has waived such rights for your Contributions to the Company

@iamjpotts
Copy link
Contributor Author

I have received written permission to make this contribution on behalf of my employer, El Toro.com, LLC.

@dustin-decker dustin-decker merged commit b3d917f into trufflesecurity:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants