add more confluence options #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufflesteeeve
approved these changes
Feb 13, 2023
| @@ -97,6 +97,8 @@ message Confluence { | |||
| bool insecure_skip_verify_tls = 6; | |||
| repeated string spaces = 7; | |||
| repeated string ignore_spaces = 8; | |||
| bool include_attachments = 9; | |||
There was a problem hiding this comment.
By default this will not include attachments. Do we want the default to include them or exclude them?
There was a problem hiding this comment.
This was intentional since it was a recent addition with major performance implications
There was a problem hiding this comment.
We'll be updating the docs soon to document all of the available options which will help discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds options to confluence for: