filesystem support for exclude and include filters (2nd attemp) #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustin-decker
approved these changes
Jan 26, 2023
javajawa
added a commit
to mewbotorg/mewbot
that referenced
this pull request
Feb 12, 2023
Sourced from trufflesecurity/trufflehog's releases. v3.27.0 What's Changed Bump golang.org/x/oauth2 from 0.3.0 to 0.4.0 by @dependabot in trufflesecurity/trufflehog#1039 add bodyclose linter to help prevent file handle leaks by @dustin-decker in trufflesecurity/trufflehog#1048 braintree detector: use production API URL instead of the test sandbo… by @swdbo in trufflesecurity/trufflehog#1054 Update float detector with correct User-Agent and regex by @ahrav in trufflesecurity/trufflehog#1061 update webex detector regex by @ahrav in trufflesecurity/trufflehog#1062 Handle errors in a thread safe manner by @ahrav in trufflesecurity/trufflehog#1052 Add TruffleHog version input for GitHub action by @mcastorina in trufflesecurity/trufflehog#1064 Revert "Add TruffleHog version input for GitHub action (#1064)" by @mcastorina in trufflesecurity/trufflehog#1068 Pull gitparse config options out of pkg consts by @bill-rich in trufflesecurity/trufflehog#1072 Add include exclude spaces for confluence source. by @ahrav in trufflesecurity/trufflehog#1073 Add max commit size by @bill-rich in trufflesecurity/trufflehog#1079 Make archive handler configurable by @bill-rich in trufflesecurity/trufflehog#1077 [chore] - Add tests for errors by @ahrav in trufflesecurity/trufflehog#1071 Skip repo and continue scanning when encountering an error by @mcastorina in trufflesecurity/trufflehog#1080 [chore] - Dont pre-allocate errors slice by @ahrav in trufflesecurity/trufflehog#1083 Add Type() to detector interface by @trufflesteeeve in trufflesecurity/trufflehog#1088 [chore] Remove logrus from engine package by @mcastorina in trufflesecurity/trufflehog#1085 [chore] Remove logrus from github source by @mcastorina in trufflesecurity/trufflehog#1086 Bump github.com/joho/godotenv from 1.4.0 to 1.5.1 by @dependabot in trufflesecurity/trufflehog#1075 [chore] Remove logrus from circleci, filesystem, gitlab, and s3 sources by @mcastorina in trufflesecurity/trufflehog#1089 [chore] - Remove monolithic config struct by @ahrav in trufflesecurity/trufflehog#1091 Make detectors configurable by @ahrav in trufflesecurity/trufflehog#1084 New Contributors @swdbo made their first contribution in trufflesecurity/trufflehog#1054 Full Changelog: trufflesecurity/trufflehog@v3.26.0...v3.27.0 v3.26.0 What's Changed Add openssh-client to trufflehog container by @mcastorina in trufflesecurity/trufflehog#1045 Bump github.com/rabbitmq/amqp091-go from 1.5.0 to 1.6.0 by @dependabot in trufflesecurity/trufflehog#1036 filesystem support for exclude and include filters (2nd attemp) by @mac2000 in trufflesecurity/trufflehog#1033 Fix the typo "programatic" by @nezakoo in trufflesecurity/trufflehog#1046 Add file to confluence proto. by @ahrav in trufflesecurity/trufflehog#1049 Remove false positive detection for CustomRegex by @mcastorina in trufflesecurity/trufflehog#1050
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I have messed up completely and somehow GitHub did not recognize that I want only my 2 commits to be merged and showed up bunch of changes from upstream 🤷♂️
Previous "broken" attempt: #881 had approve but were not merged and later on broken by me trying to fix conflicts
Closes: #536 and technically closes: #865
What has been done:
I have moved the git filter creation a little bit lower into its switch case
And created similar filter creation in the filesystem switch case
Because of that go asked me to put err := below
For filesystem engine, itself did not want to touch it so just added one more "method" WithFilter() so it can be used where needed
In the same way, as in the git source, we are checking if the filter is not nil and the current file passes it