Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Three equations model for sloshing simulations #2055

Draft
wants to merge 108 commits into
base: main
Choose a base branch
from
Draft

[WIP] Three equations model for sloshing simulations #2055

wants to merge 108 commits into from

Conversation

jmark
Copy link
Contributor

@jmark jmark commented Aug 30, 2024

This is a draft PR for the three equations model suitable, e.g., for tank sloshing simulations. As of now, this PR is primarily a backup and not ready for review. Nevertheless, interested readers are welcome to check it out and give feedback.

Johannes Markert and others added 30 commits April 8, 2024 13:04
Wrap from_abaqus routines.
95a021d
Implement geometry data transfer from t8code to Trixi.
178ec18
Updated examples.
0fed965
Fixed typos.
c50b434
Applied formatter.
5e18656
Merge branch 'main' into feature-t8code-curved-geometry
c388a94
@benegee
cubed sphere test case, copied from p4est
3bb6292
@benegee
add baroclinic instability (copy of p4est)
abbf702
@benegee
add cubed sphere constructor
5fa48e8
Fix indentation.
cd27998
Fix indentation.
f6653b0
Switching off formatter in two files.
aa4d0d4
Merge branch 'feature-t8code-curved-geometry' of github.com:trixi-fra…
f331a87 
…mework/Trixi.jl into feature-t8code-curved-geometry
Upgrading T8code.jl.
40cbb86
Merge branch 'main' into feature-t8code-curved-geometry
ff964cc
Fixed examples.
df77f82
@benegee
stress different meaning of first argument
b80f890 
it refers to level of refinement in lat lon direction, not number of
tree as in the p4est version
@benegee
use lat lon levels
c46799b
@benegee
add t8code cubed sphere tests
e3c2492
@jmark
Merge branch 'main' into feature-t8code-curved-geometry
544b10d
@benegee
Remove TODO comments
7af3f31
Relaxing T8code.jl version requirement.
6d835e3
@jmark
Merge branch 'main' into feature-t8code-curved-geometry
fe298b5
Restricted t8code version requirement.
54a5ec3
Removed cubed spherical shell related code.
1daec4b
Merge branch 'feature-t8code-curved-geometry' of github.com:trixi-fra…
5c5ccc6 
…mework/Trixi.jl into feature-t8code-curved-geometry
Removed cubed spherical shell tests.
120af75
Increasing code coverage.
4317d5e
@jmark
Merge branch 'main' into feature-t8code-curved-geometry
071d65c
Increasing code coverage.
4b5694d
jmark and others added 20 commits July 2, 2024 17:07
@jmark @JoshuaLampert
Update examples/t8code_3d_dgsem/elixir_advection_restart.jl
9e49219 
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
@jmark @JoshuaLampert
Update src/meshes/mesh_io.jl
677236f 
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
@jmark
Merge branch 'main' into feature-t8codemesh-checkpointing
6396931
@jmark @JoshuaLampert
Update examples/t8code_3d_dgsem/elixir_advection_restart.jl
404fc85 
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
@jmark @JoshuaLampert
Update src/meshes/t8code_mesh.jl
611a576 
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
@jmark
Merge branch 'main' into feature-t8codemesh-checkpointing
c8c5c20
@jmark @JoshuaLampert
Update src/meshes/t8code_mesh.jl
7161d1b 
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Removing last test in t8code 2D MPI to investigate problems in Github…
15cdc0b 
… CI.
@jmark
Merge branch 'main' into feature-t8codemesh-checkpointing
de00b40
Refactored a bit.
971d2cf
Applied formatter.
a3c169c
Removed commented code.
6383520
Added LOG_LEVEL variable.
41ebc07
Added t8code interface simplfication and stitched memory leak.
e268b33
@jmark
Merge branch 'main' into feature-t8codemesh-checkpointing
0ef1d55
Applied formatter.
1e00cb6
3D support.
74405d6
Merge branch 'feature-t8codemesh-checkpointing' into three-equations-…
4ecc7cd 
…model
Backup.
08fd656
Backup.
21fd96e
@github-actions GitHub Actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@jmark jmark marked this pull request as draft August 30, 2024 16:15
@jmark jmark changed the title [Draft] Three equations model for sloshing simulations [WIP] Three equations model for sloshing simulations Aug 30, 2024
@jmark jmark removed the discussion label Sep 3, 2024
@DanielDoehring
Copy link
Contributor

Xref: https://www.mi.uni-koeln.de/NumSim/2024/01/26/snapshot-2d-sloshing-simulation/

@DanielDoehring DanielDoehring added the enhancement New feature or request label Sep 4, 2024
@jmark jmark mentioned this pull request Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
draft enhancement New feature or request low-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmark @DanielDoehring @benegee @JoshuaLampert @ranocha