Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel #147

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Update babel #147

merged 1 commit into from
Jul 7, 2022

Conversation

marvinroger
Copy link
Contributor

This PR fixes #134 and #141

The embedded Babel version is outdated and does not support newer TypeScript syntaxes.

It would be great if you could publish a release when this PR is merged, it's a blocker for recent TypeScript projects. 😉

@marvinroger marvinroger changed the title Uodate babel Update babel Mar 24, 2022
@KilianB KilianB mentioned this pull request Mar 30, 2022
1 task
@jmfrancois
Copy link

I would prefer to use caret syntax so the end user is able to align version used in the project

Comment on lines +35 to +39
"@babel/core": "7.17.8",
"@babel/generator": "7.17.7",
"@babel/parser": "7.17.8",
"@babel/traverse": "7.17.3",
"@babel/types": "7.17.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @jmfrancois saying that it would benefit for the project to be able to align the version using the caret

Suggested change
"@babel/core": "7.17.8",
"@babel/generator": "7.17.7",
"@babel/parser": "7.17.8",
"@babel/traverse": "7.17.3",
"@babel/types": "7.17.0",
"@babel/core": "^7.17.8",
"@babel/generator": "^7.17.7",
"@babel/parser": "^7.17.8",
"@babel/traverse": "^7.17.3",
"@babel/types": "^7.17.0",

@marvinroger
Copy link
Contributor Author

@jmfrancois @romainseb I agree, but there are also advantages using locked versions, especially for an OSS project (predictability at the expense of flexibility, because e.g. a Babel release can be broken and issues would be opened on this repo).

So I'll let this PR as is, it's less opinionated that changing the version ranges, and it fixes the current issues.
Let's see what the maintainers think about the carets, then we can update the PR if it's OK for them! 😉

@jmfrancois
Copy link

a Babel release can be broken

I really trust babel because when a babel release is broken you can be sure a lot of things will be broken.

At least we are force to use resolution mecanism to align babel in most of our projects because of this little dependency . This is the only one in the middle of thousands !
Duplicates babel packages in install leads to issues and are still stuck after a month here.
This project do not move as fast as it should.
So using caret and let integrator decide which versions to use
QED

@fellnerse
Copy link

When is this going to be merged? is this repository maintained?

@amarek-godaddy
Copy link

@byara and @ayusharma I see you're listed as maintainers and I was wondering if you could give an ETA on when this might be merged and released?

@ayusharma
Copy link
Collaborator

ayusharma commented Jul 7, 2022

Hi @amarek-godaddy, Sorry for the delays. I will check it tomorrow and will try to publish next week,

@ayusharma ayusharma merged commit db8e626 into trivago:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript classes: Unexpected token
8 participants