Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add string input checks #136

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Jul 18, 2024

What does the PR do?

Move each individual check of string input in model backend repos to the bakend repo.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • refactor

Related PRs:

backend: triton-inference-server/backend#101
tensorflow_backend: triton-inference-server/tensorflow_backend#104
pytorch_backend: #136
onnxruntime_backend: triton-inference-server/onnxruntime_backend#263
python_backend: triton-inference-server/python_backend#370

Test plan:

  • CI Pipeline ID:
    17021222 and 17057045

Background

Initially just to add missing string input tensor checks to python_backend. Refactored because duplicate code from other model backends were found.

@yinggeh yinggeh added the enhancement New feature or request label Jul 18, 2024
@yinggeh yinggeh self-assigned this Jul 18, 2024
Copy link
Member

@Tabrizian Tabrizian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring.

@yinggeh yinggeh changed the title feature: Add and refactor string input checks refactor: Add and refactor string input checks Jul 30, 2024
@yinggeh yinggeh changed the title refactor: Add and refactor string input checks refactor: Add string input checks Jul 30, 2024
@yinggeh yinggeh merged commit 0d76fbf into main Jul 31, 2024
1 check passed
yinggeh added a commit that referenced this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants