Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor core input size checks #382

Merged
merged 9 commits into from
Sep 4, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Jul 23, 2024

What does the PR do?

  • Refactor core input size checks.
  • More descriptive error message.
  • Early stop in BYTES inputs check if more strings than expected.
  • Fix bug for undesired error when INT_MAX < input_byte_size <= LLONG_MAX.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • refactor

Related PRs:

triton-inference-server/server#7592

Where should the reviewer start?

n/a

Test plan:

L0_input_validation--base

  • CI Pipeline ID:
    18114270

Caveats:

n/a

Background

n/a

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

n/a

…into yinggeh-DLIS-6657-client-input-byte-size-check
rmccorm4
rmccorm4 previously approved these changes Jul 25, 2024
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but left a question out of curiosity

…into yinggeh-DLIS-6657-client-input-byte-size-check
Copy link
Contributor

@tanmayv25 tanmayv25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks more like a refactor than addition of client side byte size checks, Can you update the PR title to reflect the changes more accurately?

src/test/input_byte_size_test.cc Show resolved Hide resolved
src/test/input_byte_size_test.cc Show resolved Hide resolved
src/test/input_byte_size_test.cc Show resolved Hide resolved
@yinggeh yinggeh changed the title feat: Client input byte size checks refactor: Core input checks refactor Aug 5, 2024
@yinggeh yinggeh changed the title refactor: Core input checks refactor refactor: Core input size checks refactor Aug 5, 2024
@yinggeh yinggeh requested a review from tanmayv25 August 6, 2024 17:24
@yinggeh yinggeh changed the title refactor: Core input size checks refactor refactor: Refactor core input size checks Aug 30, 2024
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the LLONG_MAX fix as well 🚀

…into yinggeh-DLIS-6657-client-input-byte-size-check
@yinggeh yinggeh removed the request for review from tanmayv25 September 3, 2024 19:07
@yinggeh yinggeh merged commit 94eb61c into main Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants