Check the correct container during writeback #236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a model is deleted, it is deleted from both current set and update set. The existing check during writeback is on the current set, which is largely correct, but another model load thread may load the exact same model during delete, which will write the model identifier into the current set. If the delete thread sees the "deleted" model on the current set, it can cause undefined behavior. Thus, this PR modifies the writeback to check the update set, which cannot be modified by any other threads, and resolves the undefined behavior.
Different cases, if the model is:
In other words, this PR fixes the issue from number 2. Given number 3 is invalid, so there is no further behavior change aside from the fix.