[Cherry Pick] build:Extend Common Compile Settings to Protobuf #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetrini15
changed the title
mc-nv
reviewed
Jul 12, 2024
| proto-library PRIVATE | ||
| $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>: | ||
| -Wall -Wextra -Wno-unused-parameter -Werror> | ||
| $<$<CXX_COMPILER_ID:MSVC>:/W0 /D_WIN32_WINNT=0x0A00 /EHsc /Zc:preprocessor> |
There was a problem hiding this comment.
These options are responsible for:
/W0 - provide all warnings
/D_WIN32_WINNT=0x0A00 - defines version of Windows that binary compiled for.
/EHsc - specific flag to manage exceptions
/Zc:preprocessor - conformance flag for C++ language standards.
There was a problem hiding this comment.
I believe /W0 suppresses all warnings.
mc-nv
reviewed
Jul 12, 2024
| target_compile_options( | ||
| proto-library PRIVATE | ||
| $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>: | ||
| -Wall -Wextra -Wno-unused-parameter -Werror> |
There was a problem hiding this comment.
This options are responsible for:
-Wall - enable all warnings
-Wextra - enable extra warnings
-Wno-unused-parameter - can't find definition
-Werror - make all warnings as error
mc-nv
requested review from
tanmayv25 and
nnshah1
and removed request for
nnshah1
mc-nv
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Fix the Windows build which was failing to compile c++17 features due the GRPC repo bump in our third party repo.