Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Design was previously overopinionated about forcing properties to output at the grain of the related key. While we should preserve properties optimizing to the key grain if in a query together, if the key is not included in the output we should still group up the property itself.
This required refactoring of property grain handling.
As a followup, we should support more granular property syntax to enable optimization.
Specifically, these two cases should be differentiated.
Unique ID integer date key
Unique Property 1-1 with ID date text
Non-unique Property 1-many with ID date month
select
date_key,
date_text,
date_month
should still be treated as grain(datekey)
but select
date_text should be grain(datekey)
and
date_month should be grain(date_month
Type of Change
Checklist