fix: hide file tasks starting with "." (jdx#2466)

.mise/tasks/.hidden-executable

@@ -0,0 +1,4 @@
+#!/usr/bin/env bash
+set -euxo pipefail
+
+echo "this should not show as a task"

.mise/tasks/.hidden/bar/baz/hidden-executable

@@ -0,0 +1,15 @@
+#!/usr/bin/env bash
+set -euxo pipefail
+
+# Used for shellcheck which needs explicit args
+scripts=("$PWD"/scripts/*.sh "$PWD"/e2e/{test_,run_}* "$PWD"/e2e/*.sh)
+# Used for shfmt which will run only on files it can
+scripts_dirs=("$PWD"/scripts "$PWD"/e2e)
+
+cargo clippy -- -Dwarnings
+cargo fmt --all -- --check
+shellcheck -x "${scripts[@]}"
+shfmt -d -i 2 -ci -bn "${scripts_dirs[@]}"
+prettier -c $(git ls-files '*.yml' '*.yaml')
+markdownlint .
+actionlint

src/config/mod.rs

@@ -9,8 +9,8 @@ use indexmap::IndexMap;
 use itertools::Itertools;
 use once_cell::sync::{Lazy, OnceCell};
 use rayon::prelude::*;
-
 pub use settings::Settings;
+use walkdir::WalkDir;
 
 use crate::backend::Backend;
 use crate::cli::args::BackendArg;
@@ -309,7 +309,17 @@ impl Config {
     }
 
     fn load_tasks_includes(&self, root: &Path) -> Result<Vec<Task>> {
-        file::recursive_ls(root)?
+        if !root.is_dir() {
+            return Ok(vec![]);
+        }
+        let files: Vec<PathBuf> = WalkDir::new(root)
+            .follow_links(true)
+            .into_iter()
+            .filter_entry(|e| !e.file_name().to_string_lossy().starts_with('.'))
+            .filter_ok(|e| e.file_type().is_file())
+            .map_ok(|e| e.path().to_path_buf())
+            .try_collect()?;
+        files
             .into_par_iter()
             .filter(|p| file::is_executable(p))
             .map(|path| Task::from_path(&path))

src/test.rs

@@ -82,22 +82,38 @@ pub fn reset() {
     env::remove_var("MISE_FAILURE");
     file::remove_all(&*dirs::TRUSTED_CONFIGS).unwrap();
     file::remove_all(&*dirs::TRACKED_CONFIGS).unwrap();
-    file::create_dir_all(".mise/tasks").unwrap();
+    file::create_dir_all(".mise/tasks/.hidden").unwrap();
+    file::write(
+        ".mise/tasks/.hidden/executable",
+        indoc! {r#"#!/usr/bin/env bash
+        echo "this should not be a task"
+        "#},
+    )
+    .unwrap();
+    file::make_executable(".mise/tasks/.hidden/executable").unwrap();
+    file::write(
+        ".mise/tasks/.hidden-executable",
+        indoc! {r#"#!/usr/bin/env bash
+        echo "this should not be a task"
+        "#},
+    )
+    .unwrap();
+    file::make_executable(".mise/tasks/.hidden-executable").unwrap();
     file::write(
         ".mise/tasks/filetask",
         indoc! {r#"#!/usr/bin/env bash
-# mise alias=["ft"]
-# mise description="This is a test build script"
-# mise depends=["lint", "test"]
-# mise sources=[".test-tool-versions"]
-# mise outputs=["$MISE_PROJECT_ROOT/test/test-build-output.txt"]
-# mise env={TEST_BUILDSCRIPT_ENV_VAR = "VALID"}
-
-set -euxo pipefail
-cd "$MISE_PROJECT_ROOT" || exit 1
-echo "running test-build script"
-echo "TEST_BUILDSCRIPT_ENV_VAR: $TEST_BUILDSCRIPT_ENV_VAR" > test-build-output.txt
-    "#},
+        # mise alias=["ft"]
+        # mise description="This is a test build script"
+        # mise depends=["lint", "test"]
+        # mise sources=[".test-tool-versions"]
+        # mise outputs=["$MISE_PROJECT_ROOT/test/test-build-output.txt"]
+        # mise env={TEST_BUILDSCRIPT_ENV_VAR = "VALID"}
+
+        set -euxo pipefail
+        cd "$MISE_PROJECT_ROOT" || exit 1
+        echo "running test-build script"
+        echo "TEST_BUILDSCRIPT_ENV_VAR: $TEST_BUILDSCRIPT_ENV_VAR" > test-build-output.txt
+        "#},
     )
     .unwrap();
     file::make_executable(".mise/tasks/filetask").unwrap();