Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special-cased parsing for built-in attributes #163

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

maxbrunsfeld
Copy link
Contributor

@maxbrunsfeld maxbrunsfeld commented Nov 3, 2022

This is a follow-up to #93. Apologies for not weighing in on the initial discussion of that PR.

I believe pretty strongly that special handling of specific language builtins shouldn't be implemented in the parser itself. Over time, that approach will bloat the binary size of the parser, thereby making it less useful to most consumers. It will also make the parser more tightly-coupled to small changes to the language, like adding new built-in attributes.

I think the right approach was option 3. proposed in the PR body by @ninevra (which @resolritter also argued for). In this PR, I've adopted that approach.

Let me know if anyone has concerns about this, and sorry for the churn.

Parse all attribute using the general attribute syntax
@maxbrunsfeld maxbrunsfeld merged commit 3ddebf4 into master Nov 3, 2022
@maxbrunsfeld maxbrunsfeld deleted the simplify-attribute-parsing branch November 3, 2022 17:20
clason added a commit to nvim-treesitter/nvim-treesitter that referenced this pull request Nov 5, 2022
* `if_let_expression` was removed in tree-sitter/tree-sitter-rust#152
* `attributes` were reworked in
  tree-sitter/tree-sitter-rust#163 (no more
  `meta-item`)
clason added a commit to nvim-treesitter/nvim-treesitter that referenced this pull request Nov 5, 2022
* `if_let_expression` was removed in tree-sitter/tree-sitter-rust#152
* `attributes` were reworked in
  tree-sitter/tree-sitter-rust#163 (no more
  `meta-item`)
mars90226 added a commit to mars90226/dotvim that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant