Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ports to stage 7 #85

Merged
merged 3 commits into from
Nov 20, 2020

Conversation

UlrichBerntien
Copy link
Contributor

The ports discussed in issue #80 are added.

The port numbers were stored with comments inside the script.
Now the comment are added to the messages, so the user can read them.

twa Outdated Show resolved Hide resolved
@woodruffw
Copy link
Member

Left a small nit; otherwise LGTM!

@UlrichBerntien
Copy link
Contributor Author

Thanks for reviewing. The grammar mistake is corrected.
(Also I changed the wording 'listens on' in an older text. I hope this was the same mistake.)

@woodruffw
Copy link
Member

Also I changed the wording 'listens on' in an older text. I hope this was the same mistake.)

That one actually was already grammatical, but the change you made is fine 🙂

This LGTM! Will merge in a moment.

@woodruffw woodruffw merged commit fc66ea8 into trailofbits:master Nov 20, 2020
@woodruffw woodruffw mentioned this pull request Nov 20, 2020
2 tasks
@UlrichBerntien UlrichBerntien deleted the more_portscans branch November 21, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants