migrate: leiningen -> tools.deps, build.edn, kaocha #20
+119
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Drop Clojure 1.8 support: kaocha only supported 1.9+ - Remove `antq` clojure alias: use global installed antq - Remove `cloverage` make target: kaocha is configured to analyze code coverage by default - Use build.clj file instead of project.clj file for testing
liquidz
requested changes
Aug 7, 2024
.github/workflows/lint-and-test.yml
Outdated
| key: clj-cache-test-${{ hashFiles('project.clj') }} | ||
| restore-keys: | | ||
| clj-cache-test- | ||
|
|
||
| - name: Run tests | ||
| run: lein test-integration | ||
| run: make test-integration | ||
|
|
||
| - name: Run cloverage |
There was a problem hiding this comment.
This workflow uses lein command yet.
Could you delete or fix like below?
https://github.com/liquidz/antq/blob/main/.github/workflows/coverage.yml
.github/workflows/lint-and-test.yml
Outdated
| key: clj-cache-test-${{ hashFiles('project.clj') }} | ||
| restore-keys: | | ||
| clj-cache-test- | ||
|
|
||
| - name: Run tests | ||
| run: lein test-integration | ||
| run: make test-integration |
Makefile
Outdated
|
|
||
| .PHONY: clean | ||
| clean: | ||
| lein clean | ||
| rm -rf target |
There was a problem hiding this comment.
Please delete also .cpcache directory.
Co-authored-by: Iizuka Masashi <liquidz.uo@gmail.com>
|
|
without this, I got `Error: You must specify at least one clojure tool.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate: leiningen -> tools.deps, build.edn, kaocha
antqclojure alias: use global installed antqcloveragemake target: kaocha is configured to analyze code coverage by defaultfix: update copyright year
bump version: v0.2.7 -> 0.2.8
remove
:global-vars; this option for leiningen (remove for now)*warn-on-refrection*indev/user.clj.