Fix multi-path returned from _path methods on MacOS
#299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
previously approved these changes
Sep 8, 2024
Fix `site_{data,cache}_path` returning `pathlib.Path` based on the
entire `:` separated multipath under Homebrew with `multipath` enabled.
Instead, follow the approach used by `Unix` and only return the first
element if we're `multipath`
These were the only two attributes that changed when under `homebrew`
Issue: 292
auto-merge was automatically disabled
September 8, 2024 14:16
Head branch was pushed to by a user without write access
matthewhughes934
force-pushed
the
fix-macos-multipath-path-attributes
branch
from
9c77dcd
to
e2959b5
Compare
matthewhughes934
commented
Sep 8, 2024
gaborbernat
approved these changes
Sep 8, 2024
ldetmer
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Sep 9, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [platformdirs](https://redirect.github.com/platformdirs/platformdirs) | `==4.2.2` -> `==4.3.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>platformdirs/platformdirs (platformdirs)</summary> ### [`v4.3.2`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.2) [Compare Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.1...4.3.2) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Use uv as installer by [@​gaborbernat](https://redirect.github.com/gaborbernat) in [tox-dev/platformdirs#300 - Fix multi-path returned from `_path` methods on MacOS by [@​matthewhughes934](https://redirect.github.com/matthewhughes934) in [tox-dev/platformdirs#299 #### New Contributors - [@​matthewhughes934](https://redirect.github.com/matthewhughes934) made their first contribution in [tox-dev/platformdirs#299 **Full Changelog**: tox-dev/platformdirs@4.3.1...4.3.2 ### [`v4.3.1`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.1) [Compare Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.0...4.3.1) <!-- Release notes generated using configuration in .github/release.yml at main --> **Full Changelog**: tox-dev/platformdirs@4.3.0...4.3.1 ### [`v4.3.0`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.0) [Compare Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.2.2...4.3.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Speed up Hatch installation by [@​ofek](https://redirect.github.com/ofek) in [tox-dev/platformdirs#282 - Test with Python 3.13 by [@​edgarrmondragon](https://redirect.github.com/edgarrmondragon) in [tox-dev/platformdirs#289 - Test with latest PyPy by [@​edgarrmondragon](https://redirect.github.com/edgarrmondragon) in [tox-dev/platformdirs#290 - Use `include-hidden-files: true` to upload coverage artifacts by [@​edgarrmondragon](https://redirect.github.com/edgarrmondragon) in [tox-dev/platformdirs#298 - Ensure PlatformDirs is valid superclass type for mypy AND not an abstract class for other checkers by [@​Avasam](https://redirect.github.com/Avasam) in [tox-dev/platformdirs#295 #### New Contributors - [@​edgarrmondragon](https://redirect.github.com/edgarrmondragon) made their first contribution in [tox-dev/platformdirs#289 - [@​Avasam](https://redirect.github.com/Avasam) made their first contribution in [tox-dev/platformdirs#295 **Full Changelog**: tox-dev/platformdirs@4.2.2...4.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
ldetmer
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Sep 17, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [platformdirs](https://redirect.github.com/platformdirs/platformdirs) | `==4.2.2` -> `==4.3.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>platformdirs/platformdirs (platformdirs)</summary> ### [`v4.3.2`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.2) [Compare Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.1...4.3.2) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Use uv as installer by [@​gaborbernat](https://redirect.github.com/gaborbernat) in [tox-dev/platformdirs#300 - Fix multi-path returned from `_path` methods on MacOS by [@​matthewhughes934](https://redirect.github.com/matthewhughes934) in [tox-dev/platformdirs#299 #### New Contributors - [@​matthewhughes934](https://redirect.github.com/matthewhughes934) made their first contribution in [tox-dev/platformdirs#299 **Full Changelog**: tox-dev/platformdirs@4.3.1...4.3.2 ### [`v4.3.1`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.1) [Compare Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.3.0...4.3.1) <!-- Release notes generated using configuration in .github/release.yml at main --> **Full Changelog**: tox-dev/platformdirs@4.3.0...4.3.1 ### [`v4.3.0`](https://redirect.github.com/tox-dev/platformdirs/releases/tag/4.3.0) [Compare Source](https://redirect.github.com/platformdirs/platformdirs/compare/4.2.2...4.3.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Speed up Hatch installation by [@​ofek](https://redirect.github.com/ofek) in [tox-dev/platformdirs#282 - Test with Python 3.13 by [@​edgarrmondragon](https://redirect.github.com/edgarrmondragon) in [tox-dev/platformdirs#289 - Test with latest PyPy by [@​edgarrmondragon](https://redirect.github.com/edgarrmondragon) in [tox-dev/platformdirs#290 - Use `include-hidden-files: true` to upload coverage artifacts by [@​edgarrmondragon](https://redirect.github.com/edgarrmondragon) in [tox-dev/platformdirs#298 - Ensure PlatformDirs is valid superclass type for mypy AND not an abstract class for other checkers by [@​Avasam](https://redirect.github.com/Avasam) in [tox-dev/platformdirs#295 #### New Contributors - [@​edgarrmondragon](https://redirect.github.com/edgarrmondragon) made their first contribution in [tox-dev/platformdirs#289 - [@​Avasam](https://redirect.github.com/Avasam) made their first contribution in [tox-dev/platformdirs#295 **Full Changelog**: tox-dev/platformdirs@4.2.2...4.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
site_{data,cache}_pathreturningpathlib.Pathbased on the entire:separated multipath under Homebrew withmultipathenabled. Instead, follow the approach used byUnixand only return the first element if we'remultipathThese were the only two attributes that changed when under
homebrewIssue: 292