Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pin-project to 0.4 #350

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Update pin-project to 0.4 #350

merged 1 commit into from
Sep 30, 2019

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Sep 22, 2019 •
edited
Loading

Depends on tokio-rs/tokio#1586. EDIT: merged.
It may make sense to wait for the next release of tokio.

Changes: https://github.com/taiki-e/pin-project/releases/tag/v0.4.0-beta.1 (taiki-e/pin-project#90 is the biggest change in this release)

@taiki-e
Copy link
Contributor Author

taiki-e commented Sep 22, 2019

Oh, I missed the existing patches are removed on CI.

tower/ci/azure-patch-crates.yml

Line 5 in 55b5150

# Remove any existing patch statements

@taiki-e taiki-e force-pushed the pin-project branch 2 times, most recently from fab19b6 to ffd8d1e Compare September 22, 2019 17:01
@taiki-e taiki-e marked this pull request as ready for review September 22, 2019 18:00
@taiki-e taiki-e mentioned this pull request Sep 22, 2019
Merged
@LucioFranco
Copy link
Member

@taiki-e thanks, yeah lets wait for the next release.

@taiki-e taiki-e changed the title Update pin-project to 0.4.0-beta.1 Update pin-project to 0.4 Sep 25, 2019
LucioFranco
LucioFranco approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified these changes locally 👍 I think we need to wait for this update to bubble up the stack though.

@jonhoo jonhoo mentioned this pull request Sep 30, 2019
Merged
LucioFranco
LucioFranco approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this <3

@LucioFranco LucioFranco merged commit 03dc706 into tower-rs:v0.3.x Sep 30, 2019
@taiki-e taiki-e deleted the pin-project branch September 30, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @LucioFranco