pkp#10306 added not to perform assertion on void return type method

tests/jobs/bulk/BulkEmailSenderTest.php

@@ -70,6 +70,8 @@ public function testRunSerializedJob(): void
 
         app()->instance(UserRepository::class, $userRepoMock);
 
-        $this->assertNull($bulkEmailSenderJob->handle());
+        $bulkEmailSenderJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/doi/DepositContextTest.php

@@ -79,6 +79,8 @@ public function testRunSerializedJob(): void
 
         app()->instance(DoiRepository::class, $doiRepoMock);
 
-        $this->assertNull($depositContextJob->handle());
+        $depositContextJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/doi/DepositSubmissionTest.php

@@ -135,6 +135,8 @@ public function testRunSerializedJob(): void
 
         app()->instance(DoiRepository::class, $doiRepoMock);
 
-        $this->assertNull($depositSubmissionJob->handle());
+        $depositSubmissionJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/email/EditorialReminderTest.php

@@ -208,6 +208,8 @@ public function testRunSerializedJob(): void
 
         app()->instance(EmailTemplateRepository::class, $emailTemplateRepoMock);
 
-        $this->assertNull($editorialReminderJob->handle());
+        $editorialReminderJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/invitations/RemoveExpiredInvitationsJobTest.php

@@ -47,8 +47,9 @@ public function testRunSerializedJob(): void
         /** @var RemoveExpiredInvitationsJob $removeExpiredInvitationsJob */
         $removeExpiredInvitationsJob = unserialize($this->serializedJobData);
 
-        // Test that the job can be handled without causing an exception.
-        $this->assertNull($removeExpiredInvitationsJob->handle());
+        $removeExpiredInvitationsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
 

tests/jobs/metadata/BatchMetadataChangedJobTest.php

@@ -102,6 +102,8 @@ public function testRunSerializedJob(): void
         DAORegistry::registerDAO('MonographSearchDAO', $submissionSearchDAOMock);   // for OMP
         DAORegistry::registerDAO('PreprintSearchDAO', $submissionSearchDAOMock);    // for OPS
 
-        $this->assertNull($batchMetadataChangedJob->handle());
+        $batchMetadataChangedJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/metadata/MetadataChangedJobTest.php

@@ -102,6 +102,8 @@ public function testRunSerializedJob(): void
         DAORegistry::registerDAO('MonographSearchDAO', $submissionSearchDAOMock);   // for OMP
         DAORegistry::registerDAO('PreprintSearchDAO', $submissionSearchDAOMock);    // for OPS
 
-        $this->assertNull($metadataChangedJob->handle());
+        $metadataChangedJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/notifications/NewAnnouncementNotifyUsersTest.php

@@ -121,6 +121,8 @@ public function testRunSerializedJob(): void
 
         app()->instance(UserRepository::class, $userRepoMock);
 
-        $this->assertNull($newAnnouncementNotifyUsersJob->handle());
+        $newAnnouncementNotifyUsersJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/notifications/StatisticsReportMailTest.php

@@ -144,6 +144,8 @@ public function testRunSerializedJob(): void
 
         app()->instance(UserRepository::class, $userRepoMock);
 
-        $this->assertNull($statisticsReportMailJob->handle());
+        $statisticsReportMailJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/notifications/StatisticsReportNotifyTest.php

@@ -58,6 +58,8 @@ public function testRunSerializedJob(): void
 
         app()->instance(UserRepository::class, $userRepoMock);
 
-        $this->assertNull($statisticsReportNotifyJob->handle());
+        $statisticsReportNotifyJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/statistics/ArchiveUsageStatsLogFileTest.php

@@ -58,7 +58,7 @@ public function testRunSerializedJob(): void
         // we need to create a dummy file if not existed as to avoid mocking PHP's built in functions
         $dummyFileName = $this->createDummyFileIfNeeded($archiveUsageStatsLogFileJob, 'loadId');
 
-        $this->assertNull($archiveUsageStatsLogFileJob->handle());
+        $archiveUsageStatsLogFileJob->handle();
 
         if ($dummyFileName) {
             unlink(
@@ -69,6 +69,8 @@ public function testRunSerializedJob(): void
                     .$dummyFileName
             );
         }
+
+        $this->expectNotToPerformAssertions();
     }
 
     /**

tests/jobs/statistics/CompileContextMetricsTest.php

@@ -59,6 +59,8 @@ public function testRunSerializedJob(): void
 
         DAORegistry::registerDAO('TemporaryTotalsDAO', $temporaryTotalsDAOMock);
 
-        $this->assertNull($compileContextMetricsJob->handle());
+        $compileContextMetricsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/statistics/CompileMonthlyMetricsTest.php

@@ -72,6 +72,8 @@ public function testRunSerializedJob(): void
 
         app()->instance('sushiStats', $statsSushiService);
 
-        $this->assertNull($compileMonthlyMetricsJob->handle());
+        $compileMonthlyMetricsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/statistics/CompileSubmissionMetricsTest.php

@@ -59,6 +59,8 @@ public function testRunSerializedJob(): void
 
         DAORegistry::registerDAO('TemporaryTotalsDAO', $temporaryTotalsDAOMock);
 
-        $this->assertNull($compileSubmissionMetricsJob->handle());
+        $compileSubmissionMetricsJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/statistics/RemoveDoubleClicksTest.php

@@ -59,6 +59,8 @@ public function testRunSerializedJob(): void
 
         DAORegistry::registerDAO('TemporaryTotalsDAO', $temporaryTotalsDAOMock);
 
-        $this->assertNull($removeDoubleClicksJob->handle());
+        $removeDoubleClicksJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }

tests/jobs/submissions/RemoveSubmissionFileFromSearchIndexJobTest.php

@@ -59,8 +59,9 @@ public function testRunSerializedJob(): void
         DAORegistry::registerDAO('MonographSearchDAO', $submissionSearchDAOMock);   // for OMP
         DAORegistry::registerDAO('PreprintSearchDAO', $submissionSearchDAOMock);    // for OPS
 
-        // Test that the job can be handled without causing an exception.
-        $this->assertNull($removeSubmissionFileFromSearchIndexJob->handle());
+        $removeSubmissionFileFromSearchIndexJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
 

tests/jobs/submissions/RemoveSubmissionFromSearchIndexJobTest.php

@@ -59,8 +59,9 @@ public function testRunSerializedJob(): void
         DAORegistry::registerDAO('MonographSearchDAO', $submissionSearchDAOMock);   // for OMP
         DAORegistry::registerDAO('PreprintSearchDAO', $submissionSearchDAOMock);    // for OPS
 
-        // Test that the job can be handled without causing an exception.
-        $this->assertNull($removeSubmissionFromSearchIndexJob->handle());
+        $removeSubmissionFromSearchIndexJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }
 

tests/jobs/submissions/UpdateSubmissionSearchJobTest.php

@@ -58,8 +58,9 @@ public function testRunSerializedJob(): void
 
         app()->instance(\APP\submission\Repository::class, $mock);
 
-        // Test that the job can be handled without causing an exception.
-        $this->assertNull($updateSubmissionSearchJob->handle());
+        $updateSubmissionSearchJob->handle();
+
+        $this->expectNotToPerformAssertions();
     }
 }