Make "attempted to kill init" message more clear #438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopsided98
pushed a commit
to lopsided98/linux
that referenced
this pull request
Apr 27, 2019
lkl-upstream: fix make install to install liblkl.a
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 15, 2021
This commit fixes the following checkpatch.pl errors:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#14: FILE: ./hal/odm_DIG.c:14:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#30: FILE: ./hal/odm_DIG.c:30:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#41: FILE: ./hal/odm_DIG.c:41:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#51: FILE: ./hal/odm_DIG.c:51:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#59: FILE: ./hal/odm_DIG.c:59:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#72: FILE: ./hal/odm_DIG.c:72:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#136: FILE: ./hal/odm_DIG.c:136:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#208: FILE: ./hal/odm_DIG.c:208:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#236: FILE: ./hal/odm_DIG.c:236:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#325: FILE: ./hal/odm_DIG.c:325:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#326: FILE: ./hal/odm_DIG.c:326:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#365: FILE: ./hal/odm_DIG.c:365:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#366: FILE: ./hal/odm_DIG.c:366:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#438: FILE: ./hal/odm_DIG.c:438:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#469: FILE: ./hal/odm_DIG.c:469:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#470: FILE: ./hal/odm_DIG.c:470:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#507: FILE: ./hal/odm_DIG.c:507:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#510: FILE: ./hal/odm_DIG.c:510:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#826: FILE: ./hal/odm_DIG.c:826:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#895: FILE: ./hal/odm_DIG.c:895:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#896: FILE: ./hal/odm_DIG.c:896:
+ struct false_ALARM_STATISTICS * FalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1065: FILE: ./hal/odm_DIG.c:1065:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1081: FILE: ./hal/odm_DIG.c:1081:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1082: FILE: ./hal/odm_DIG.c:1082:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1083: FILE: ./hal/odm_DIG.c:1083:
+ struct false_ALARM_STATISTICS * pFalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1137: FILE: ./hal/odm_DIG.c:1137:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1138: FILE: ./hal/odm_DIG.c:1138:
+ struct false_ALARM_STATISTICS * FalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1198: FILE: ./hal/odm_DIG.c:1198:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1199: FILE: ./hal/odm_DIG.c:1199:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 16, 2021
This commit fixes the following checkpatch.pl errors:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#14: FILE: ./hal/odm_DIG.c:14:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#30: FILE: ./hal/odm_DIG.c:30:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#41: FILE: ./hal/odm_DIG.c:41:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#51: FILE: ./hal/odm_DIG.c:51:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#59: FILE: ./hal/odm_DIG.c:59:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#72: FILE: ./hal/odm_DIG.c:72:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#136: FILE: ./hal/odm_DIG.c:136:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#208: FILE: ./hal/odm_DIG.c:208:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#236: FILE: ./hal/odm_DIG.c:236:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#325: FILE: ./hal/odm_DIG.c:325:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#326: FILE: ./hal/odm_DIG.c:326:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#365: FILE: ./hal/odm_DIG.c:365:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#366: FILE: ./hal/odm_DIG.c:366:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#438: FILE: ./hal/odm_DIG.c:438:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#469: FILE: ./hal/odm_DIG.c:469:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#470: FILE: ./hal/odm_DIG.c:470:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#507: FILE: ./hal/odm_DIG.c:507:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#510: FILE: ./hal/odm_DIG.c:510:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#826: FILE: ./hal/odm_DIG.c:826:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#895: FILE: ./hal/odm_DIG.c:895:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#896: FILE: ./hal/odm_DIG.c:896:
+ struct false_ALARM_STATISTICS * FalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1065: FILE: ./hal/odm_DIG.c:1065:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1081: FILE: ./hal/odm_DIG.c:1081:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1082: FILE: ./hal/odm_DIG.c:1082:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1083: FILE: ./hal/odm_DIG.c:1083:
+ struct false_ALARM_STATISTICS * pFalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1137: FILE: ./hal/odm_DIG.c:1137:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1138: FILE: ./hal/odm_DIG.c:1138:
+ struct false_ALARM_STATISTICS * FalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1198: FILE: ./hal/odm_DIG.c:1198:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1199: FILE: ./hal/odm_DIG.c:1199:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210315170618.2566-24-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Aug 24, 2021
I got the possible circular locking dependency detected report: [ 52.472106][ T483] ====================================================== [ 52.473212][ T483] WARNING: possible circular locking dependency detected [ 52.474322][ T483] 5.14.0-rc6-next-20210820+ torvalds#438 Not tainted [ 52.475272][ T483] ------------------------------------------------------ [ 52.476385][ T483] systemd-udevd/483 is trying to acquire lock: [ 52.477356][ T483] ffffffff8c5d45a8 (mtd_table_mutex){+.+.}-{3:3}, at: blktrans_open.cold.18+0x44/0x4b1 [ 52.480510][ T483] [ 52.480510][ T483] but task is already holding lock: [ 52.481664][ T483] ffff88810eff8918 (&disk->open_mutex){+.+.}-{3:3}, at: blkdev_get_by_dev+0x428/0x910 [ 52.483164][ T483] [ 52.483164][ T483] which lock already depends on the new lock. [ 52.483164][ T483] [ 52.484578][ T483] [ 52.484578][ T483] the existing dependency chain (in reverse order) is: [ 52.485803][ T483] [ 52.485803][ T483] -> #1 (&disk->open_mutex){+.+.}-{3:3}: [ 52.486888][ T483] __mutex_lock+0x140/0x15d0 [ 52.487599][ T483] bd_register_pending_holders+0xb9/0x302 [ 52.488463][ T483] device_add_disk+0x375/0xcf0 [ 52.489198][ T483] add_mtd_blktrans_dev+0x11a4/0x16f0 [ 52.490019][ T483] mtdblock_add_mtd+0x21a/0x2b0 [ 52.490771][ T483] blktrans_notify_add+0xae/0xdb [ 52.491531][ T483] add_mtd_device.cold.26+0xa98/0xc98 [ 52.492348][ T483] mtd_device_parse_register+0x516/0x870 [ 52.493201][ T483] mtdram_init_device+0x294/0x350 [ 52.493966][ T483] init_mtdram+0xde/0x16e [ 52.494644][ T483] do_one_initcall+0x105/0x650 [ 52.495381][ T483] kernel_init_freeable+0x6aa/0x732 [ 52.496171][ T483] kernel_init+0x1c/0x1c0 [ 52.496847][ T483] ret_from_fork+0x1f/0x30 [ 52.497530][ T483] [ 52.497530][ T483] -> #0 (mtd_table_mutex){+.+.}-{3:3}: [ 52.498591][ T483] __lock_acquire+0x2cfa/0x5990 [ 52.499343][ T483] lock_acquire+0x1a0/0x500 [ 52.500041][ T483] __mutex_lock+0x140/0x15d0 [ 52.500749][ T483] blktrans_open.cold.18+0x44/0x4b1 [ 52.501545][ T483] blkdev_get_whole+0x9f/0x280 [ 52.502282][ T483] blkdev_get_by_dev+0x593/0x910 [ 52.503041][ T483] blkdev_open+0x154/0x2a0 [ 52.503726][ T483] do_dentry_open+0x6a9/0x1260 [ 52.504461][ T483] path_openat+0xe06/0x2850 [ 52.505160][ T483] do_filp_open+0x1b0/0x280 [ 52.505857][ T483] do_sys_openat2+0x60e/0x9a0 [ 52.506576][ T483] do_sys_open+0xca/0x140 [ 52.507251][ T483] do_syscall_64+0x38/0xb0 [ 52.507936][ T483] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 52.508822][ T483] [ 52.508822][ T483] other info that might help us debug this: [ 52.508822][ T483] [ 52.510218][ T483] Possible unsafe locking scenario: [ 52.510218][ T483] [ 52.511240][ T483] CPU0 CPU1 [ 52.511975][ T483] ---- ---- [ 52.512708][ T483] lock(&disk->open_mutex); [ 52.513342][ T483] lock(mtd_table_mutex); [ 52.514295][ T483] lock(&disk->open_mutex); [ 52.515276][ T483] lock(mtd_table_mutex); [ 52.515884][ T483] [ 52.515884][ T483] *** DEADLOCK *** load module path: open device path: init_mtdram() add_mtd_device() mutex_lock(&mtd_table_mutex) blktrans_notifier() add_mtd() blkdev_get_by_dev() mutex_lock(&disk->open_mutex) blktrans_open() mutex_lock(&mtd_table_mutex); bd_register_pending_holders() mutex_lock(&disk->open_mutex) add_mtd() is called under mtd_table_mutex, before it acquires open_mutex, open_mutex may be acquired by another cpu when opening the device, and it will wait for mtd_table_mutex which is already acquired, then the 'ABBA' deadlock scenario is happend, reduce the mtd_table_mutex to avoid this. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel panic occurs as a result of init being successfully killed. I believe this is a clearer message, as it describes that the process has been killed, not merely that there was an attempt.
kill -9 1is an example of an attempt to kill init, that does not succeed. Thus, I believe changing the message to "init was killed" or similar helps to differentiate between attempts, and successful attempts that cause kernel panics.The exact message may of course be amended, but I believe it is important that the successful nature of the process kill is noted, in order for better debugging.