Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Support #320

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Windows Support #320

merged 3 commits into from
Jul 2, 2020

Conversation

Uakh
Copy link
Contributor

@Uakh Uakh commented Jul 2, 2020

Multiprocessing cannot use lambdas on Windows due to limitations with pickle. Additionally wandb currently does not run correctly on Windows wandb/wandb#862 therefore we recommend disabling it in the troubleshooting section of the readme

Uakh and others added 3 commits July 2, 2020 14:57
On Windows, lambas cannot be pickled and therefore dispatched to worker pools with multiprocessing.
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #320 into master will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   66.88%   66.90%   +0.01%     
==========================================
  Files         144      144              
  Lines       10907    10907              
  Branches     1473     1469       -4     
==========================================
+ Hits         7295     7297       +2     
  Misses       3198     3198              
+ Partials      414      412       -2     
Flag Coverage Δ
#unittests 66.90% <50.00%> (+0.01%) ⬆️
Impacted Files Coverage Δ
torch_points3d/trainer.py 74.26% <0.00%> (ø)
torch_points3d/datasets/base_dataset.py 70.07% <66.66%> (+0.37%) ⬆️
...ch_points3d/core/data_transform/feature_augment.py 65.15% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feabb96...017c4e4. Read the comment docs.

Copy link
Member

@nicolas-chaulet nicolas-chaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@nicolas-chaulet nicolas-chaulet merged commit f54a5cc into torch-points3d:master Jul 2, 2020
ggrzeczkowicz pushed a commit to umrlastig/torch-points3d that referenced this pull request Oct 11, 2022
* Fix filepath parsing on Windows

* Windows support

On Windows, lambas cannot be pickled and therefore dispatched to worker pools with multiprocessing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants