Fix tags/environment variables collection #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleocadie
force-pushed
the
gleocadie/fix-bug-merge-scenario-metadata-with-configuration-metadata
branch
from
46bae8f
to
2f07a90
Compare
tonyredondo
approved these changes
Jul 19, 2023
gleocadie
deleted the
gleocadie/fix-bug-merge-scenario-metadata-with-configuration-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today, when collecting tags for each scenario results, we apply the one from the scenario but not the ones from the configuration (global scope).
Which in most cases sets not tags for each result.
This PR tries to fix it by merging the tags from the configuration and the scenario together. In case of a duplicate, we keep the value from the scenario (what has already been done for environment variables)