Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only analyze files that are children of the targets in build() #225

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

devdanzin
Copy link
Collaborator

When building, wily creates lists of target files to scan based on added and modified files from the git repository. It's possible to pass a path to wily build, but it won't currently avoid scanning files outside of the path.

This PR makes wily only scan files that are children of the chosen path during build. This is an improvement for building in repositories that contains large files that aren't interesting to analyze. The behavior remains unchanged if no path is passed to wily build.

This addresses a TODO in build.py, adapting some commented out code:

# TODO : Check that changed files are children of the targets

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.81%. Comparing base (2590691) to head (4761779).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   95.86%   94.81%   -1.06%     
==========================================
  Files          25       25              
  Lines        1403     1407       +4     
  Branches      296      297       +1     
==========================================
- Hits         1345     1334      -11     
- Misses         33       48      +15     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants