Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): Clarify results in profiler #769

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

epage
Copy link
Member

@epage epage commented Jul 29, 2024

Be removing the extra closure, it somehow made things easier to read (despite using closures in so many other places).

This is also closer to where I want the parser to be long term.

Be removing the extra closure, it somehow made things easier to read
(despite using closures in so many other places).

This is also closer to where I want the parser to be long term.
crates/toml_edit/src/parser/array.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/array.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/array.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/array.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/inline_table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/inline_table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/inline_table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/inline_table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/value.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/parser/value.rs Fixed Show fixed Hide fixed
@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10150631252

Details

  • 54 of 60 (90.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 67.428%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/toml_edit/src/parser/array.rs 14 15 93.33%
crates/toml_edit/src/parser/inline_table.rs 18 19 94.74%
crates/toml_edit/src/parser/mod.rs 17 21 80.95%
Totals Coverage Status
Change from base Build 10150546886: 0.4%
Covered Lines: 3691
Relevant Lines: 5474

💛 - Coveralls

@epage epage merged commit d29eb7a into toml-rs:main Jul 29, 2024
15 checks passed
@epage epage deleted the check branch July 29, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants