-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended regex to work with pandoc version 3 #29
base: master
Are you sure you want to change the base?
Conversation
Thanks, @nandokawka for this PR. In my experience, this PR resolves the following issue. I used Then I ran a pandoc script and got this error:
Next, I installed the new code from this PR: pip3 install --force-reinstall git+https://github.com/nandokawka/pandoc-xnos@284474574f51888be75603e7d1df667a0890504d#egg=pandoc-xnos When I rerun the pandoc script, the error is gone. |
i copied the above approach (thanks for that!) only actually refering to this PR here, not the one of the fork. I am no expert, but this seems more trustworthy for my personal taste:
|
Hi @tomduck could I please ask if you plan to merge this PR? Thank you! |
Thanks @nandokawka, this also fixed the issue for me. While we're waiting for the merge, I used @bvorak's approach to install from the patched version. |
Just ran into tomduck/pandoc-eqnos#68 which gets fixed by this PR, I would be very interested in seeing this being released... |
Likewise. I was just using pandoc-fignos with the latest pandoc (pandoc-3.1.4/pandoc-cli-0.1.1.1) and I hit this bug. The fix proposed worked for me. I'd be great to see it published. |
The regex check only allows for pandoc versions 2.X. This creates an error for all people upgrading to pandoc versions 3.X.