Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor building from pairs #129

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Refactor building from pairs #129

merged 2 commits into from
Feb 10, 2023

Conversation

branchseer
Copy link
Contributor

Implementations of FromIterator::from_iter and Visitor::visit_map share a lot of repeated code about building a Slab from pairs. This PR extracts it into a Builder.

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/lib.rs Outdated Show resolved Hide resolved
Co-authored-by: Taiki Endo <te316e89@gmail.com>
@taiki-e taiki-e merged commit 0eaabe8 into tokio-rs:master Feb 10, 2023
@Darksonn Darksonn mentioned this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants