Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to get vacant key without mutable access #114

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Add method to get vacant key without mutable access #114

merged 2 commits into from
Mar 23, 2022

Conversation

binier
Copy link
Contributor

@binier binier commented Mar 17, 2022

Same as slab.vacant_entry().key() without requiring mutable access.

@binier
Add method to get vacant key without mutable access
e83bcc4 
Same as `slab.vacant_entry().key()` without requiring mutable access.
taiki-e
taiki-e approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

hawkw
hawkw requested changes Mar 17, 2022
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions for the docs.

src/lib.rs Outdated Show resolved Hide resolved
@binier @hawkw
improve Slab::vacant_key() docs
dd07f7e 
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
hawkw
hawkw approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me --- thanks for the docs changes!

@taiki-e taiki-e merged commit 711e24a into tokio-rs:master Mar 23, 2022
@taiki-e taiki-e mentioned this pull request Mar 27, 2022
Merged
@binier binier deleted the patch-1 branch April 7, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binier @hawkw @taiki-e