Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When connecting to url without http:// weird things are happening #401

Closed
dpc opened this issue Feb 8, 2023 · 0 comments · Fixed by #486
Closed

When connecting to url without http:// weird things are happening #401

dpc opened this issue Feb 8, 2023 · 0 comments · Fixed by #486
Labels
S-bug Severity: bug

Comments

@dpc
Copy link

dpc commented Feb 8, 2023 •
edited
Loading

What crate(s) in this repo are involved in the problem?

tokio-console

What is the issue?

First time using tokio-console, I did tokio-console 127.0.0.1:1234 and it kind of worked, not really. The display is blank, but when changing its size it displays something update reconnecting and t = tasks, r = resources, but doesn't seem to update anything.

Eventually I figured out that I'm supposed to do tokio-console http://127.0.0.1:1234 and that gives me the UI.

How can the bug be reproduced?

tokio-console 127.0.0.1:1234 (no http://)

Logs, error output, etc

No response

Versions

> tokio-console -V
tokio-console 0.1.7

Possible solution

No response

Additional context

No response

Would you like to work on fixing this bug?

no
@dpc dpc added the S-bug Severity: bug label Feb 8, 2023
@Rustin170506 Rustin170506 mentioned this issue Nov 2, 2023
Merged
@hds hds closed this as completed in #486 Nov 3, 2023
hds pushed a commit that referenced this issue Nov 3, 2023
@Rustin170506
fix(console): accept only file://, http://, https:// URI (#486)
031bddd 
Tokio console can connect to a console subscriber over HTTP or
(on UNIX) via a socket. However, no check was performed to
ensure that the server string matched the HTTP(S) or FILE protocols.
This was reported to lead to strange behavior (#401).

This change adds an explicit check on the URI scheme to ensure that
it is one of `http`, `https`, or `file`.

closes: #401

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-bug Severity: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(console): only accept file, http://, https:// URI Rustin170506/console
1 participant
@dpc