Is it posible to add/update/remove router when program is running? #1395
-
Feature RequestMotivationIt seems that router is confirmed before program runs. Is there any way to add a router when pogram is running? ProposalI'm sorry that I have no idea about how to realize the idea。 |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 3 replies
-
|
Yes that is possible. I'm curious why you need that though. Like if you were able to write |
Beta Was this translation helpful? Give feedback.
-
|
I designed a plug-in mechanism to read a dynamic library to hot load and update routers |
Beta Was this translation helpful? Give feedback.
-
|
I see. That sounds pretty cool! I'm not sure adding routes directly to the But if you really do wanna replace the router here is one way to do it: use axum::{
body::Body,
http::Request,
routing::{get, post},
Extension, Router, Json,
};
use std::net::SocketAddr;
use tokio::sync::{mpsc, oneshot};
use tower::{make::Shared, ServiceExt};
use serde::Deserialize;
#[tokio::main]
async fn main() {
let (tx, rx) = mpsc::channel::<RouterMsg>(1024);
tokio::spawn(handle_router_msg(rx));
let service = tower::service_fn(move |request: Request<Body>| {
let (router_tx, router_rx) = oneshot::channel();
let tx = tx.clone();
async {
tx.send(RouterMsg::GetRouter { reply: router_tx })
.await
.unwrap_or_else(|_| panic!("failed to send"));
let router = router_rx.await.expect("failed to get current router");
let router = router.layer(Extension(tx));
router.oneshot(request).await
}
});
let addr = SocketAddr::from(([127, 0, 0, 1], 3000));
axum::Server::bind(&addr)
.serve(Shared::new(service))
.await
.unwrap();
}
enum RouterMsg {
GetRouter {
reply: oneshot::Sender<Router>,
},
UpdateRouter {
update_router: Box<dyn FnOnce(Router) -> Router + Send>,
},
}
async fn handle_router_msg(mut rx: mpsc::Receiver<RouterMsg>) {
let mut router = Router::new().route("/routes", post(add_route));
while let Some(msg) = rx.recv().await {
match msg {
RouterMsg::GetRouter { reply } => {
reply
.send(router.clone())
.expect("failed to send router back");
}
RouterMsg::UpdateRouter { update_router } => {
let new_router = update_router(router);
router = new_router;
}
}
}
}
#[derive(Deserialize)]
struct Params {
route: String,
}
async fn add_route(
Extension(tx): Extension<mpsc::Sender<RouterMsg>>,
Json(params): Json<Params>,
) {
let update_router = Box::new(move |router: Router| {
// `Router::route` might panic, so you probably wanna either catch that
// or do your own tracking of which routes have been added
router.route(¶ms.route, get(|| async { "Hi from new route!" }))
});
tx.send(RouterMsg::UpdateRouter { update_router })
.await
.unwrap_or_else(|_| panic!("failed to send"));
} |
Beta Was this translation helpful? Give feedback.
-
|
Thanks a lot! Maybe use a map is a better idea. |
Beta Was this translation helpful? Give feedback.
Yes that is possible. I'm curious why you need that though. Like if you were able to write
axum::router::get_app_router().nest("/newrouter", get(service));, where doesservicecome from? You gotta have it defined when you compile your code. So is it a matter of enabling/disabling endpoints? That feels like simpler and can be done by having some shared state that you update and either check in middleware or in handlers.