Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: util: static ref deref return type #3392

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Feb 3, 2023

Pull Request Overview

I updated the Rust compiler to a February 2023 nightly, and encountered build errors. Specifically:

error: impl method assumes more implied bounds than the corresponding trait method
  --> kernel/src/utilities/static_ref.rs:40:24
   |
40 |     fn deref(&self) -> &'static T {
   |                        ^^^^^^^^^^ help: replace this type to make the impl signature compatible: `&T`
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #105572 <https://github.com/rust-lang/rust/issues/105572>

Again, this changes a very core file, which I don't think should be swept up in an "Update Nightly" pr.

Testing Strategy

This pull request was tested by travis.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

Update return type with new compiler error.
@github-actions github-actions bot added the kernel label Feb 3, 2023
@lschuermann lschuermann added the last-call Final review period for a pull request. label Feb 17, 2023
@hudson-ayers
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 20, 2023

@bors bors bot merged commit bad91fd into master Feb 20, 2023
@bors bors bot deleted the implied-bounds-staticref branch February 20, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel last-call Final review period for a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants