Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key-value support #488

Merged
merged 8 commits into from
Feb 2, 2024
Merged

Add key-value support #488

merged 8 commits into from
Feb 2, 2024

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Aug 1, 2023

This adds the api and an example app for key-value.

This is blocked on two things:

  1. platform: subscribe: add return code variants #487 - we need the new upcall conversion types
  2. KV: Separate virtualization from KV implementation, New KV trait, Set/Add/Update tock#3551 - we should wait until the kernel settles down before actually merging this. The userspace code won't change that much, and I wanted to open this PR to get any feedback.

@bradjc bradjc mentioned this pull request Aug 2, 2023
46 tasks
@jrvanwhy
Copy link
Collaborator

jrvanwhy commented Aug 9, 2023

Are you planning to add a fake version of the key-value syscall driver once tock/tock#3551 is stabilized? If so, great. If not, then we should probably have a discussion on whether we want to require unit tests for all API implementations.

@jrvanwhy jrvanwhy added the upkeep Indicates a PR is upkeep as defined by the code review policy. label Aug 22, 2023
@bradjc
Copy link
Contributor Author

bradjc commented Jan 10, 2024

I added a unittest implementation.

@bradjc
Copy link
Contributor Author

bradjc commented Feb 1, 2024

This should be ready to go.

jrvanwhy
jrvanwhy previously approved these changes Feb 1, 2024
Cargo.toml Outdated
@@ -16,7 +16,7 @@ version = "0.1.0"
rust-version = "1.70"

[dependencies]
libtock_adc = { path = "apis/adc" }
libtock_adc = { path = "apis/adc"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reformatting looks accidental.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@jrvanwhy jrvanwhy added this pull request to the merge queue Feb 2, 2024
Merged via the queue into master with commit 767b1d8 Feb 2, 2024
3 checks passed
@jrvanwhy jrvanwhy deleted the kv branch February 2, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep Indicates a PR is upkeep as defined by the code review policy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants