Skip to content

Commit

Permalink
fix(tests): explicitly state the shell to use
Browse files Browse the repository at this point in the history
`tmux` uses the default login shell and thus tests might fail if this is
not bash (or something compatible). Explicitly stating which shell to
use circumvents issues arising from accidentally using another shell.
  • Loading branch information
zappolowski committed Nov 1, 2022
1 parent 629a8fb commit e800c99
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions tests/workspace/test_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -880,6 +880,8 @@ def test_find_current_active_pane(server, monkeypatch):
textwrap.dedent(
"""
session_name: Should not execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command: echo "___$((1 + 3))___"
Expand All @@ -893,6 +895,8 @@ def test_find_current_active_pane(server, monkeypatch):
textwrap.dedent(
"""
session_name: Should not execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command:
Expand All @@ -907,6 +911,8 @@ def test_find_current_active_pane(server, monkeypatch):
textwrap.dedent(
"""
session_name: Should execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command: echo "___$((1 + 3))___"
Expand All @@ -919,6 +925,8 @@ def test_find_current_active_pane(server, monkeypatch):
textwrap.dedent(
"""
session_name: Should execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command:
Expand All @@ -932,6 +940,8 @@ def test_find_current_active_pane(server, monkeypatch):
textwrap.dedent(
"""
session_name: Should not execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command:
Expand All @@ -946,6 +956,8 @@ def test_find_current_active_pane(server, monkeypatch):
textwrap.dedent(
"""
session_name: Should not execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command:
Expand All @@ -960,6 +972,8 @@ def test_find_current_active_pane(server, monkeypatch):
textwrap.dedent(
"""
session_name: Should execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command: echo "___$((1 + 3))___"
Expand All @@ -972,6 +986,8 @@ def test_find_current_active_pane(server, monkeypatch):
textwrap.dedent(
"""
session_name: Should execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command:
Expand Down Expand Up @@ -1033,6 +1049,8 @@ def fn():
textwrap.dedent(
"""
session_name: Should not execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command:
Expand All @@ -1049,6 +1067,8 @@ def fn():
textwrap.dedent(
"""
session_name: Should not execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command:
Expand All @@ -1065,6 +1085,8 @@ def fn():
textwrap.dedent(
"""
session_name: Should not execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command:
Expand All @@ -1079,6 +1101,8 @@ def fn():
textwrap.dedent(
"""
session_name: Should not execute
options:
default-shell: /bin/bash
windows:
- panes:
- shell_command:
Expand All @@ -1093,6 +1117,8 @@ def fn():
textwrap.dedent(
"""
session_name: Should not execute
options:
default-shell: /bin/bash
shell_command_before:
- cmd: echo "sleeping before"
sleep_before: .5
Expand Down

0 comments on commit e800c99

Please sign in to comment.