Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Add use of Defined outputparser in LLMChain #929

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erictse
Copy link
Contributor

@erictse erictse commented Jun 24, 2024

Note to maintainers

Hi, @tmc!

While this example works, there are a number of issues I have that you can help walk me through.

  1. LLMChain doesn't consider the outputparser's format instructions when sending the prompt. It seems a good solution should, but that might be a departure from Python LangChain (not sure) and would need consideration on how to not break things.
  2. There's a type assertion to extract the output struct from the outputparser which is unwieldy and unexpected necessary due to https://github.com/tmc/langchaingo/blob/main/chains/llm.go#L53 where the map value must be type any.

For both these issues, I'm not sure I see a solution that behaves like LangChain yet is practical. It leads me to wonder, as far would you be interested in deviating from LangChain and building what is optimal based on both Go and the technical opinions by leadership on this project?

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant