Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
The
--preserve
andN_PRESERVE_NPM
features just covernpm
(andnpx
) but notcorepack
. Users may wish to preservecorepack
as well.See: #735
Solution
It seems reasonable for
--preserve
to preservecorepack
too.corepack
is distributed as an npm package, but it is not part of npm as such. Add a separate environment variable rather than lump it under the existing one.--preserve
covercorepack
as wellN_PRESERVE_COREPACK
(rather than includecorepack
inN_PRESERVE_NPM
)ChangeLog
corepack
when use--preserve
N_PRESERVE_COREPACK