Obsolete some of the AutomationProperties (dotnet#13104)

* Obsolete some of the AutomationProperties

* Update SemanticProperties.cs

src/Compatibility/Core/src/Android/FastRenderers/AutomationPropertiesProvider.cs

@@ -92,6 +92,7 @@ void OnElementChanged(object sender, VisualElementChangedEventArgs e)
 
 		void OnElementPropertyChanged(object sender, PropertyChangedEventArgs e)
 		{
+#pragma warning disable CS0618 // Type or member is obsolete
 			if (e.PropertyName == AutomationProperties.HelpTextProperty.PropertyName)
 			{
 				SetContentDescription();
@@ -108,6 +109,7 @@ void OnElementPropertyChanged(object sender, PropertyChangedEventArgs e)
 			{
 				SetLabeledBy();
 			}
+#pragma warning restore CS0618 // Type or member is obsolete
 		}
 	}
 }

src/Compatibility/Core/src/Windows/AccessibilityExtensions.cs

@@ -22,9 +22,13 @@ static string ConcatenateNameAndHint(Element Element)
 		{
 			string separator;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			var name = (string)Element.GetValue(AutomationProperties.NameProperty);
+#pragma warning restore CS0618 // Type or member is obsolete
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			var hint = (string)Element.GetValue(AutomationProperties.HelpTextProperty);
+#pragma warning restore CS0618 // Type or member is obsolete
 
 
 			if (string.IsNullOrWhiteSpace(name) || string.IsNullOrWhiteSpace(hint))

src/Controls/src/Core/AutomationProperties.cs

@@ -1,10 +1,13 @@
 #nullable disable
+using System;
+
 namespace Microsoft.Maui.Controls
 {
 	/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="Type[@FullName='Microsoft.Maui.Controls.AutomationProperties']/Docs/*" />
 	public class AutomationProperties
 	{
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='HelpTextProperty']/Docs/*" />
+		[Obsolete("Use SemanticProperties.Hint instead. See the conceptual docs about accessibility for more information.")]
 		public static readonly BindableProperty HelpTextProperty = BindableProperty.Create("HelpText", typeof(string), typeof(AutomationProperties), default(string));
 
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='IsInAccessibleTreeProperty']/Docs/*" />
@@ -13,15 +16,19 @@ public class AutomationProperties
 		public static readonly BindableProperty ExcludedWithChildrenProperty = BindableProperty.Create("ExcludedWithChildren", typeof(bool?), typeof(AutomationProperties), null);
 
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='LabeledByProperty']/Docs/*" />
+		[Obsolete("Use a SemanticProperties.Description binding instead. See the conceptual docs about accessibility for more information.")]
 		public static readonly BindableProperty LabeledByProperty = BindableProperty.Create("LabeledBy", typeof(VisualElement), typeof(AutomationProperties), default(VisualElement));
 
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='NameProperty']/Docs/*" />
+		[Obsolete("Use SemanticProperties.Description instead. See the conceptual docs about accessibility for more information.")]
 		public static readonly BindableProperty NameProperty = BindableProperty.Create("Name", typeof(string), typeof(AutomationProperties), default(string));
 
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='GetHelpText']/Docs/*" />
 		public static string GetHelpText(BindableObject bindable)
 		{
+#pragma warning disable CS0618 // Type or member is obsolete
 			return (string)bindable.GetValue(HelpTextProperty);
+#pragma warning restore CS0618 // Type or member is obsolete
 		}
 
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='GetIsInAccessibleTree']/Docs/*" />
@@ -39,19 +46,25 @@ public static string GetHelpText(BindableObject bindable)
 		[System.ComponentModel.TypeConverter(typeof(ReferenceTypeConverter))]
 		public static VisualElement GetLabeledBy(BindableObject bindable)
 		{
+#pragma warning disable CS0618 // Type or member is obsolete
 			return (VisualElement)bindable.GetValue(LabeledByProperty);
+#pragma warning restore CS0618 // Type or member is obsolete
 		}
 
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='GetName']/Docs/*" />
 		public static string GetName(BindableObject bindable)
 		{
+#pragma warning disable CS0618 // Type or member is obsolete
 			return (string)bindable.GetValue(NameProperty);
+#pragma warning restore CS0618 // Type or member is obsolete
 		}
 
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='SetHelpText']/Docs/*" />
 		public static void SetHelpText(BindableObject bindable, string value)
 		{
+#pragma warning disable CS0618 // Type or member is obsolete
 			bindable.SetValue(HelpTextProperty, value);
+#pragma warning restore CS0618 // Type or member is obsolete
 		}
 
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='SetIsInAccessibleTree']/Docs/*" />
@@ -68,13 +81,17 @@ public static void SetExcludedWithChildren(BindableObject bindable, bool? value)
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='SetLabeledBy']/Docs/*" />
 		public static void SetLabeledBy(BindableObject bindable, VisualElement value)
 		{
+#pragma warning disable CS0618 // Type or member is obsolete
 			bindable.SetValue(LabeledByProperty, value);
+#pragma warning restore CS0618 // Type or member is obsolete
 		}
 
 		/// <include file="../../docs/Microsoft.Maui.Controls/AutomationProperties.xml" path="//Member[@MemberName='SetName']/Docs/*" />
 		public static void SetName(BindableObject bindable, string value)
 		{
+#pragma warning disable CS0618 // Type or member is obsolete
 			bindable.SetValue(NameProperty, value);
+#pragma warning restore CS0618 // Type or member is obsolete
 		}
 	}
 }

src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/CellRenderer.cs

@@ -76,6 +76,7 @@ public virtual void SetAccessibility(UITableViewCell tableViewCell, Cell cell)
 			else
 				tableViewCell.AccessibilityElementsHidden = false;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			if (cell.IsSet(AutomationProperties.NameProperty))
 				tableViewCell.AccessibilityLabel = cell.GetValue(AutomationProperties.NameProperty).ToString();
 			else
@@ -85,6 +86,8 @@ public virtual void SetAccessibility(UITableViewCell tableViewCell, Cell cell)
 				tableViewCell.AccessibilityHint = cell.GetValue(AutomationProperties.HelpTextProperty).ToString();
 			else
 				tableViewCell.AccessibilityHint = null;
+#pragma warning restore CS0618 // Type or member is obsolete
+
 		}
 
 		public virtual void SetBackgroundColor(UITableViewCell tableViewCell, Cell cell, UIColor color)

src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs

@@ -861,7 +861,9 @@ static void SetAccessibilityHint(UIBarButtonItem uIBarButtonItem, Element elemen
 			if (_defaultAccessibilityHint == null)
 				_defaultAccessibilityHint = uIBarButtonItem.AccessibilityHint;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			uIBarButtonItem.AccessibilityHint = (string)element.GetValue(AutomationProperties.HelpTextProperty) ?? _defaultAccessibilityHint;
+#pragma warning restore CS0618 // Type or member is obsolete
 		}
 
 		static void SetAccessibilityLabel(UIBarButtonItem uIBarButtonItem, Element element)
@@ -872,7 +874,9 @@ static void SetAccessibilityLabel(UIBarButtonItem uIBarButtonItem, Element eleme
 			if (_defaultAccessibilityLabel == null)
 				_defaultAccessibilityLabel = uIBarButtonItem.AccessibilityLabel;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			uIBarButtonItem.AccessibilityLabel = (string)element.GetValue(AutomationProperties.NameProperty) ?? _defaultAccessibilityLabel;
+#pragma warning restore CS0618 // Type or member is obsolete
 		}
 
 		static void SetIsAccessibilityElement(UIBarButtonItem uIBarButtonItem, Element element)

src/Controls/src/Core/Compatibility/Handlers/VisualElementRenderer.cs

@@ -35,9 +35,11 @@ public abstract partial class VisualElementRenderer<TElement> : IPlatformViewHan
 			[nameof(VisualElement.BackgroundColor)] = MapBackgroundColor,
 			[AutomationProperties.IsInAccessibleTreeProperty.PropertyName] = MapAutomationPropertiesIsInAccessibleTree,
 #if WINDOWS
+#pragma warning disable CS0618 // Type or member is obsolete
 			[AutomationProperties.NameProperty.PropertyName] = MapAutomationPropertiesName,
 			[AutomationProperties.HelpTextProperty.PropertyName] = MapAutomationPropertiesHelpText,
 			[AutomationProperties.LabeledByProperty.PropertyName] = MapAutomationPropertiesLabeledBy,
+#pragma warning restore CS0618 // Type or member is obsolete
 #endif
 		};
 

src/Controls/src/Core/Compatibility/iOS/Extensions/AccessibilityExtensions.cs

@@ -33,7 +33,9 @@ public static string SetAccessibilityHint(this NativeView Control, Element Eleme
 			if (_defaultAccessibilityHint == null)
 				_defaultAccessibilityHint = Control.AccessibilityHint;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			Control.AccessibilityHint = (string)Element.GetValue(AutomationProperties.HelpTextProperty) ?? _defaultAccessibilityHint;
+#pragma warning restore CS0618 // Type or member is obsolete
 #else
 			if (_defaultAccessibilityHint == null)
 				_defaultAccessibilityHint = Control.AccessibilityTitle;
@@ -52,7 +54,9 @@ public static string SetAccessibilityLabel(this NativeView Control, Element Elem
 			if (_defaultAccessibilityLabel == null)
 				_defaultAccessibilityLabel = Control.AccessibilityLabel;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			Control.AccessibilityLabel = (string)Element.GetValue(AutomationProperties.NameProperty) ?? _defaultAccessibilityLabel;
+#pragma warning restore CS0618 // Type or member is obsolete
 
 			return _defaultAccessibilityLabel;
 		}
@@ -66,7 +70,9 @@ public static string SetAccessibilityHint(this UIBarItem Control, Element Elemen
 			if (_defaultAccessibilityHint == null)
 				_defaultAccessibilityHint = Control.AccessibilityHint;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			Control.AccessibilityHint = (string)Element.GetValue(AutomationProperties.HelpTextProperty) ?? _defaultAccessibilityHint;
+#pragma warning restore CS0618 // Type or member is obsolete
 
 			return _defaultAccessibilityHint;
 
@@ -80,7 +86,9 @@ public static string SetAccessibilityLabel(this UIBarItem Control, Element Eleme
 			if (_defaultAccessibilityLabel == null)
 				_defaultAccessibilityLabel = Control.AccessibilityLabel;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			Control.AccessibilityLabel = (string)Element.GetValue(AutomationProperties.NameProperty) ?? _defaultAccessibilityLabel;
+#pragma warning restore CS0618 // Type or member is obsolete
 
 			return _defaultAccessibilityLabel;
 		}

src/Controls/src/Core/Compatibility/iOS/Extensions/ToolbarItemExtensions.cs

@@ -75,10 +75,12 @@ void OnPropertyChanged(object sender, PropertyChangedEventArgs e)
 							UpdateTextAndStyle();
 					}
 				}
+#pragma warning disable CS0618 // Type or member is obsolete
 				else if (e.PropertyName == AutomationProperties.HelpTextProperty.PropertyName)
 					this.SetAccessibilityHint(_item);
 				else if (e.PropertyName == AutomationProperties.NameProperty.PropertyName)
 					this.SetAccessibilityLabel(_item);
+#pragma warning restore CS0618 // Type or member is obsolete
 			}
 
 			void UpdateIconAndStyle()
@@ -149,9 +151,11 @@ void OnPropertyChanged(object sender, PropertyChangedEventArgs e)
 					UpdateIcon();
 				else if (e.PropertyName == MenuItem.IsEnabledProperty.PropertyName)
 					UpdateIsEnabled();
+#pragma warning disable CS0618 // Type or member is obsolete
 				else if (e.PropertyName == AutomationProperties.HelpTextProperty.PropertyName)
 					this.SetAccessibilityHint(_item);
 				else if (e.PropertyName == AutomationProperties.NameProperty.PropertyName)
+#pragma warning restore CS0618 // Type or member is obsolete
 					this.SetAccessibilityLabel(_item);
 			}
 

src/Controls/src/Core/Platform/Android/AutomationPropertiesProvider.cs

@@ -79,8 +79,10 @@ static string ConcatenateNameAndHint(Element Element)
 		{
 			string separator;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			var name = (string)Element.GetValue(AutomationProperties.NameProperty);
 			var hint = (string)Element.GetValue(AutomationProperties.HelpTextProperty);
+#pragma warning restore CS0618 // Type or member is obsolete
 
 			if (string.IsNullOrWhiteSpace(name) || string.IsNullOrWhiteSpace(hint))
 				separator = "";
@@ -166,7 +168,9 @@ internal static void SetLabeledBy(AView control, Element element)
 			if (element == null || control == null)
 				return;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			var elemValue = (VisualElement)element.GetValue(AutomationProperties.LabeledByProperty);
+#pragma warning restore CS0618 // Type or member is obsolete
 
 			if (elemValue != null)
 			{
@@ -232,8 +236,10 @@ internal static void AccessibilitySettingsChanged(AView control, Element element
 
 		internal static string ConcatenateNameAndHelpText(BindableObject Element)
 		{
+#pragma warning disable CS0618 // Type or member is obsolete
 			var name = (string)Element.GetValue(AutomationProperties.NameProperty);
 			var helpText = (string)Element.GetValue(AutomationProperties.HelpTextProperty);
+#pragma warning restore CS0618 // Type or member is obsolete
 
 			if (string.IsNullOrWhiteSpace(name))
 				return helpText;

src/Controls/src/Core/Platform/Windows/Extensions/AccessibilityExtensions.cs

@@ -20,7 +20,9 @@ public static string SetAutomationPropertiesName(this FrameworkElement Control,
 			if (_defaultAutomationPropertiesName == null)
 				_defaultAutomationPropertiesName = (string)Control.GetValue(NativeAutomationProperties.NameProperty);
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			var elemValue = (string)Element.GetValue(AutomationProperties.NameProperty);
+#pragma warning restore CS0618 // Type or member is obsolete
 
 			if (!string.IsNullOrWhiteSpace(elemValue))
 				Control.SetValue(NativeAutomationProperties.NameProperty, elemValue);
@@ -60,7 +62,9 @@ public static string SetAutomationPropertiesHelpText(this FrameworkElement Contr
 			if (_defaultAutomationPropertiesHelpText == null)
 				_defaultAutomationPropertiesHelpText = (string)Control.GetValue(NativeAutomationProperties.HelpTextProperty);
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			var elemValue = (string)Element.GetValue(AutomationProperties.HelpTextProperty);
+#pragma warning restore CS0618 // Type or member is obsolete
 
 			if (!string.IsNullOrWhiteSpace(elemValue))
 				Control.SetValue(NativeAutomationProperties.HelpTextProperty, elemValue);
@@ -85,16 +89,18 @@ public static UIElement SetAutomationPropertiesLabeledBy(
 
 			if (_defaultAutomationPropertiesLabeledBy == null)
 				_defaultAutomationPropertiesLabeledBy = (UIElement)Control.GetValue(NativeAutomationProperties.LabeledByProperty);
-
+#pragma warning disable CS0618 // Type or member is obsolete
 			var elemValue = (VisualElement)Element.GetValue(AutomationProperties.LabeledByProperty);
-
+#pragma warning restore CS0618 // Type or member is obsolete
 			FrameworkElement nativeElement = null;
 
 			if (mauiContext != null)
 				nativeElement = (elemValue as IView)?.ToHandler(mauiContext)?.PlatformView as FrameworkElement;
 
 			if (nativeElement != null)
+#pragma warning disable CS0618 // Type or member is obsolete
 				Control.SetValue(AutomationProperties.LabeledByProperty, nativeElement);
+#pragma warning restore CS0618 // Type or member is obsolete
 			else
 				Control.SetValue(NativeAutomationProperties.LabeledByProperty, _defaultAutomationPropertiesLabeledBy);
 
@@ -117,10 +123,11 @@ static string ConcatenateNameAndHint(Element Element)
 		{
 			string separator;
 
+#pragma warning disable CS0618 // Type or member is obsolete
 			var name = (string)Element.GetValue(AutomationProperties.NameProperty);
 
 			var hint = (string)Element.GetValue(AutomationProperties.HelpTextProperty);
-
+#pragma warning restore CS0618 // Type or member is obsolete
 
 			if (string.IsNullOrWhiteSpace(name) || string.IsNullOrWhiteSpace(hint))
 				separator = "";

src/Controls/src/Core/SemanticProperties.cs

@@ -47,9 +47,11 @@ public static void SetHeadingLevel(BindableObject bindable, SemanticHeadingLevel
 			SemanticProperties.DescriptionProperty,
 			SemanticProperties.HintProperty,
 			SemanticProperties.HeadingLevelProperty,
+#pragma warning disable CS0618 // Type or member is obsolete
 			AutomationProperties.NameProperty,
 			AutomationProperties.LabeledByProperty,
 			AutomationProperties.HelpTextProperty,
+#pragma warning restore CS0618 // Type or member is obsolete
 			AutomationProperties.IsInAccessibleTreeProperty,
 		};