runtime: add runtime.fcntl link directives #4481
Open
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
leongross
force-pushed
the
runtim/fcntl
branch
from
aaf0e21
to
0dc68ce
Compare
aykevl
reviewed
Sep 28, 2024
| //go:linkname syscall_fcntl runtime/runtime.fcntl | ||
| func syscall_fcntl(fd, cmd, arg int32) (ret int32, errno int32) { | ||
| // https://cs.opensource.google/go/go/+/master:src/runtime/os_linux.go;l=452?q=runtime.fcntl&ss=go%2Fgo | ||
| r, _, err := Syscall6(SYS_FCNTL, uintptr(fd), uintptr(cmd), uintptr(arg), 0, 0, 0) |
There was a problem hiding this comment.
Why are you trying to do a direct system call in syscall_libc.go? Syscall6 and the like are only supported on Windows and Linux, not on many other systems.
What about calling the libc function fcntl instead?
Comment on lines
+145
to
+147
| func fcntl(fd, cmd, arg int32) (ret int32, errno int32){ | ||
| return 0, 0 | ||
| } |
There was a problem hiding this comment.
This is a bad idea. It should not just ignore the call and return without an error.
Is this intended to call syscall_fcntl perhaps?
And then, any reason not to call the libc function instead (like with syscall_Getpagesize for example).
| @@ -212,6 +212,13 @@ func Truncate(path string, length int64) (err error) { | |||
| return | |||
| } | |||
|
|
|||
| //go:linkname syscall_fcntl runtime/runtime.fcntl | |||
There was a problem hiding this comment.
I think you meant runtime.fcntl?
Suggested change
| //go:linkname syscall_fcntl runtime/runtime.fcntl | |
| //go:linkname syscall_fcntl runtime.fcntl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building u-root commands with tinygo (see u-root/u-root#2979) returns linking errors for the system runtime function
runtime.fcntl. This PR intends to fix this issue. Affected u-root cmdlets: