Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xvd support to Template device parition rendering #786

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

chrisdoherty4
Copy link
Member

Add xvd support support for applying partitions numbers in Tinkerbell Template rendering using the formatPartition function.

xvd are a virtual device on Xen virtual machines.

Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
@chrisdoherty4 chrisdoherty4 added the ready-to-merge Signal to Mergify to merge the PR. label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #786 (67a0b14) into main (47ec6ff) will increase coverage by 0.20%.
The diff coverage is 0.00%.

❗ Current head 67a0b14 differs from pull request most recent head 703a6e0. Consider uploading reports for the commit 703a6e0 to get more accurate results

@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
+ Coverage   50.96%   51.16%   +0.20%     
==========================================
  Files          33       33              
  Lines        1456     1456              
==========================================
+ Hits          742      745       +3     
+ Misses        670      665       -5     
- Partials       44       46       +2     
Files Changed Coverage Δ
internal/workflow/template_funcs.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 changed the title Add xvda support to Template device parition rendering Add xvd support to Template device parition rendering Sep 5, 2023
@mergify mergify bot merged commit aab3c67 into tinkerbell:main Sep 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants